Skip to content

bpo-1635741: Port _queue to multiphase initialization - #23376

Merged
miss-islington merged 2 commits into
python:masterfrom
tiran:bpo-1635741-queue
Nov 19, 2020
Merged

bpo-1635741: Port _queue to multiphase initialization#23376
miss-islington merged 2 commits into
python:masterfrom
tiran:bpo-1635741-queue

Conversation

@tiran

@tirantiran commented Nov 18, 2020

Copy link
Copy Markdown
Member

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue1635741

Automerge-Triggered-By: GH:tiran

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suggest to use PyModule_AddObjectRef() to make the code even better :-)

Comment threadModules/_queuemodule.c Outdated

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update.

Comment threadModules/_queuemodule.c
@miss-islington

Copy link
Copy Markdown
Contributor

@tiran: Status check is done, and it's a success ✅ .

@miss-islington
miss-islington merged commit 3094dd5 into python:masterNov 19, 2020
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Shared 3.x has failed when building commit 3094dd5.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/483/builds/403) and take a look at the build logs.
  4. Check if the failure is related to this commit (3094dd5) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/483/builds/403

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

404 tests OK.

10 slowest tests:

  • test_cmd_line: 4 min 40 sec
  • test_concurrent_futures: 4 min 15 sec
  • test_multiprocessing_spawn: 2 min 38 sec
  • test_unparse: 2 min 37 sec
  • test_tokenize: 2 min 35 sec
  • test_multiprocessing_forkserver: 2 min 25 sec
  • test_asyncio: 1 min 39 sec
  • test_capi: 1 min 37 sec
  • test_multiprocessing_fork: 1 min 35 sec
  • test_subprocess: 1 min 32 sec

1 test altered the execution environment:
test_concurrent_futures

20 tests skipped:
test_dbm_gnu test_devpoll test_epoll test_gdb test_idle test_ioctl
test_msilib test_ossaudiodev test_spwd test_startfile test_tcl
test_tix test_tk test_ttk_guionly test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 14 min 1 sec

Click to see traceback logs
Traceback (most recent call last):
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "<string>", line 1, in <module>
File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 116, in spawn_main
File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 116, in spawn_main
exitcode = _main(fd, parent_sentinel)
exitcode = _main(fd, parent_sentinel)
File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 126, in _main
File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 126, in _mainself= reduction.pickle.load(from_parent)
self= reduction.pickle.load(from_parent)
File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 110, in __setstate__
File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 110, in __setstate__self._semlock = _multiprocessing.SemLock._rebuild(*state)
self._semlock = _multiprocessing.SemLock._rebuild(*state)
FileNotFoundError: [Errno 2] No such file or directoryFileNotFoundError: [Errno 2] No such file or directory
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 116, in spawn_main
exitcode = _main(fd, parent_sentinel)
File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 126, in _mainself= reduction.pickle.load(from_parent)
File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 110, in __setstate__self._semlock = _multiprocessing.SemLock._rebuild(*state)
FileNotFoundError: [Errno 2] No such file or directory
Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2)
Warning -- Dangling thread: <Thread(QueueFeederThread, started daemon 34420633600)>
Warning -- Dangling thread: <_MainThread(MainThread, started 34374492160)>
Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2)
Warning -- Dangling thread: <_MainThread(MainThread, started 34374492160)>
Warning -- Dangling thread: <Thread(QueueFeederThread, started daemon 34420633600)>
/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: There appear to be 3 leaked semaphore objects to clean up at shutdown
warnings.warn('resource_tracker: There appear to be %d '
Warning -- Unraisable exception
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/util.py", line 224, in __call__
res =self._callback(*self._args, **self._kwargs)
File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 87, in _cleanup
sem_unlink(name)
FileNotFoundError: [Errno 2] No such file or directory
Warning -- Unraisable exception
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/util.py", line 224, in __call__
res =self._callback(*self._args, **self._kwargs)
File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 87, in _cleanup
sem_unlink(name)
FileNotFoundError: [Errno 2] No such file or directory
Warning -- Unraisable exception
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/util.py", line 224, in __call__
res =self._callback(*self._args, **self._kwargs)
File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 87, in _cleanup
sem_unlink(name)
FileNotFoundError: [Errno 2] No such file or directory

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Signed-off-by: Christian Heimes <christian@python.org>
Automerge-Triggered-By: GH:tiran
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tiran@miss-islington@bedevere-bot@vstinner@the-knights-who-say-ni