Uh oh!
There was an error while loading. Please reload this page.
bpo-39529: Deprecate creating new event loop in asyncio.get_event_loop() - #23554
Conversation
serhiy-storchaka
commented
Nov 29, 2020
It is a draft. Tests which use |
Uh oh!
There was an error while loading. Please reload this page.
serhiy-storchaka
commented
Dec 6, 2020
Ready for review. |
| loop = events.get_event_loop() | ||
| task = loop.create_task(coro_or_future) | ||
| if task._source_traceback: | ||
| del task._source_traceback[-1] |
There was a problem hiding this comment.
It was removed because this code did not work as intented long time ago (if worked at all).
| res = loop.run_until_complete(asyncio.wait_for(coro(), timeout=None)) | ||
| self.assertEqual(res, 'done') | ||
| def test_wait_for_with_global_loop(self): |
There was a problem hiding this comment.
It is virtually a duplicate of the above test. Initially they were different by passing the loop argument or not, now it is removed
| self.assertAlmostEqual(0.15, loop.time()) | ||
| self.assertEqual(res, 42) | ||
| def test_wait_with_global_loop(self): |
There was a problem hiding this comment.
It is virtually a duplicate of the above test. Initially they were different by passing the loop argument or not, now it is removed
| self.assertEqual(y, 'b') | ||
| self.assertAlmostEqual(0.10, loop.time()) | ||
| x = loop.run_until_complete(futs[1]) |
There was a problem hiding this comment.
Currently two parts of the test was virtually duplicates. Added new tests (test_as_completed_coroutine_without_loop and below) which are essentially different.
serhiy-storchaka
commented
Dec 6, 2020
Please give attention to tests. This is the main part of the PR. |
This PR is stale because it has been open for 30 days with no activity. |
asvetlov
left a comment
There was a problem hiding this comment.
LGTM, please go ahead.
Sorry for the very long review.
https://bugs.python.org/issue39529