Uh oh!
There was an error while loading. Please reload this page.
bpo-42562: Fix issue when dis failed to parse function that has no line numbers - #23632
Conversation
markshannon
commented
Dec 4, 2020
uriyyo
commented
Dec 4, 2020
@markshannon I have updated test. Should I also revert |
markshannon
left a comment
There was a problem hiding this comment.
Needs a comment, otherwise LGTM.
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot
commented
Dec 4, 2020
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
uriyyo
commented
Dec 4, 2020
I have made the requested changes; please review again |
bedevere-bot
commented
Dec 4, 2020
Thanks for making the requested changes! @markshannon: please review the changes made to this pull request. |
uriyyo
commented
Dec 4, 2020
Should we update PR title and |
markshannon
commented
Dec 4, 2020
Yes. Something like "has no line numbers" instead of "has only annotations" |
uriyyo
commented
Dec 4, 2020
I have updated PR title and |
…ne numbers (pythonGH-23632) Fix issue when dis failed to parse function that has only annotations
https://bugs.python.org/issue42562