Skip to content

bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 2 - #23838

Merged
corona10 merged 4 commits into
python:masterfrom
erlend-aasland:bpo-40956/part2b-con
Dec 27, 2020
Merged

bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 2#23838
corona10 merged 4 commits into
python:masterfrom
erlend-aasland:bpo-40956/part2b-con

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Dec 18, 2020•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aasland

erlend-aasland commented Dec 18, 2020

Copy link
Copy Markdown
ContributorAuthor

@corona10, here's the rest of _sqlite3.Connection.

@corona10
corona10 self-requested a review December 19, 2020 01:20
ghost
ghost approved these changes Dec 22, 2020
View reviewed changes

@ghostghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10

corona10 commented Dec 23, 2020

Copy link
Copy Markdown
Member

@erlend-aasland I will take a look at this PR by this weekend ;) Sorry for the delay!

corona10
corona10 requested changes Dec 26, 2020
View reviewed changes
Comment threadModules/_sqlite/connection.c
Comment threadModules/_sqlite/connection.c
@bedevere-bot

bedevere-bot commented Dec 26, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

corona10
corona10 reviewed Dec 26, 2020
View reviewed changes

@corona10corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check all arguments specs before submitting the patch ;)

@erlend-aasland

erlend-aasland commented Dec 26, 2020

Copy link
Copy Markdown
ContributorAuthor

I have made the requested changes; please review again

@corona10
corona10 merged commit 3ccef1c into python:masterDec 27, 2020
@erlend-aasland
erlend-aasland deleted the bpo-40956/part2b-con branch December 27, 2020 10:01
This was referenced Dec 27, 2020
Merged
Merged
@erlend-aaslanderlend-aasland mentioned this pull request Feb 10, 2021
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland@adorilson
bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 2 (py…
07aebb4
…thonGH-23838)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10corona10corona10 approved these changes
@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@corona10@bedevere-bot@the-knights-who-say-ni