Uh oh!
There was an error while loading. Please reload this page.
bpo-28837: Fix lib2to3 handling of map/zip/filter - #24
Merged
Conversation
… followed with a 'trailer', e.g. zip()[x]
Codecov Report@@ Coverage Diff @@## master #24 +/- ##
==========================================
+ Coverage 82.37% 82.37% +<.01%
==========================================
Files 1427 1427 Lines 350948 351009 +61 ==========================================
+ Hits 289088 289144 +56 - Misses 61860 61865 +5Continue to review full report at Codecov.
|
stuarteberg
commented
Feb 15, 2017
ContributorAuthor
@benjaminp: Are you the right person to ping about |
| | | ||
| power< | ||
| 'map' trailer< '(' [arglist=any] ')' > | ||
| 'map' args=trailer< '(' [any] ')' > |
Contributor
There was a problem hiding this comment.
What's the reason for this change?
ContributorAuthor
There was a problem hiding this comment.
What's the reason for this change?
On line 100 (below), I need to clone the argument list:
new=Node(syms.power, [Name("map"), args.clone()])If I leave the above line unchanged, then I could have written this, instead:
new=Node(syms.power, [Name("map"), ArgList([args.clone()])])...but there's a problem with that: It doesn't clone the ( and ) tokens -- it creates them from scratch. As a result, one of the tests fails, due to an unpreserved prefix before the ) token:
======================================================================
FAIL: test_prefix_preservation (Lib.lib2to3.tests.test_fixers.Test_map)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/bergs/Documents/workspace/cpython-git/Lib/lib2to3/tests/test_fixers.py", line 3036, in test_prefix_preservation
self.check(b, a)
File "/Users/bergs/Documents/workspace/cpython-git/Lib/lib2to3/tests/test_fixers.py", line 3031, in check
super(Test_map, self).check(b, a)
File "/Users/bergs/Documents/workspace/cpython-git/Lib/lib2to3/tests/test_fixers.py", line 36, in check
tree = self._check(before, after)
File "/Users/bergs/Documents/workspace/cpython-git/Lib/lib2to3/tests/test_fixers.py", line 32, in _check
self.assertEqual(after, str(tree))
AssertionError: "x = list(map( f, 'abc' ))\n\n" != "x = list(map( f, 'abc'))\n\n"
- x = list(map( f, 'abc' ))
? ---
+ x = list(map( f, 'abc'))
Hence, I think it's best to capture and clone the whole trailer. But if I'm missing something, please let me know.
Contributor
There was a problem hiding this comment.
Okay, thanks for the explanation.
Mariatta added a commit
that referenced
this pull request
Jun 16, 2017
jaraco pushed a commit
that referenced
this pull request
Dec 2, 2022
jaraco pushed a commit
to jaraco/cpython
that referenced
this pull request
Feb 17, 2023
Refactor into Python 3 and Python 2.7 submodules.
nanjekyejoannah added a commit
to nanjekyejoannah/cpython
that referenced
this pull request
Mar 10, 2023
24: Warn for exception: move warning to ceval r=ltratt a=nanjekyejoannah This replaces the old PR: softdevteam#12 Moved the warning to ceval. I removed the three component warning because it was committed in an earlier PR here: softdevteam#14 Co-authored-by: Joannah Nanjekye <jnanjeky@unb.ca>
Fidget-Spinner referenced
this pull request
in pylbbv/pylbbv
May 27, 2023
Implemented type propagation
oraluben pushed a commit
to oraluben/cpython
that referenced
this pull request
Jun 25, 2023
This was referenced Feb 11, 2025
StanFromIreland referenced
this pull request
in StanFromIreland/cpython
Dec 6, 2025
Eclips4 pushed a commit
to Eclips4/cpython
that referenced
this pull request
Mar 10, 2026
This PR pretty much completely refactors the Rust build system. There are now two main ways Rust code is built: # both - The Rust triple is deduced based on the preprocessor run on Misc/platform_triplet.c - A cpython-build-helper crate is used to pass the proper link arguments for each configuration - The proper Rust toolchain is downloaded for iOS/Android/WASI for CI on those platforms - cpython-sys is updated significantly to ensure bindgen properly generates the bindings for each platform # shared For shared builds, we build a crate into a cdylib and pass through link arguments from the makefile/configure and the linker executable so that the final link will match what is done for C programs. # static For static builds, a cpython-rust-staticlib crate is a built which depends on and re-exports the module initializers for each crate. This ensures there aren't duplicated Rust stdlib/core symbols. Fixespython#23
raul-sq added a commit
to raul-sq/cpython
that referenced
this pull request
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
2to3tool will automatically wrap calls tomap,zip, andfilterwithlist():...but the tool misses some cases, if the call is followed by a "trailer" such as
[0]:This PR augments the
lib2to3"fixers" formap,zip, andfilterto correctly handle such cases.http://bugs.python.org/issue28837