Skip to content

[3.9] bpo-42822: Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" - #24092

Merged
JulienPalard merged 1 commit into
3.9from
revert-23827-backport-dcc997c-3.9
Jan 4, 2021
Merged

[3.9] bpo-42822: Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)"#24092
JulienPalard merged 1 commit into
3.9from
revert-23827-backport-dcc997c-3.9

Conversation

@JulienPalard

@JulienPalardJulienPalard commented Jan 4, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-botbedevere-bot added docs Documentation in the Doc dir awaiting core review labels Jan 4, 2021
@JulienPalard

JulienPalard commented Jan 4, 2021

Copy link
Copy Markdown
MemberAuthor

Hum no, a full revert is not needed, only some bits has to be reverted, let me check this in details.

@JulienPalard
Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (…
b806721
…GH-23658)"
This partially reverts commit
e89993c, which was removing
backslashes in documentations compiled with Sphinx < 3, used for
Python 3.8 and 3.9 docs.
@JulienPalard
JulienPalardforce-pushed the revert-23827-backport-dcc997c-3.9 branch from 946dfdd to b806721CompareJanuary 4, 2021 12:46
@JulienPalard

JulienPalard commented Jan 4, 2021

Copy link
Copy Markdown
MemberAuthor

I kept only backslashes involved in strings, which looks to be the only one causing troubles.

@JulienPalardJulienPalard changed the title Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)"bpo-42822: Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)"Jan 4, 2021
@JulienPalardJulienPalard changed the title bpo-42822: Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)"[3.9] bpo-42822: Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)"Jan 4, 2021
andresdelfino
andresdelfino approved these changes Jan 4, 2021
View reviewed changes

@andresdelfinoandresdelfino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JulienPalard
JulienPalard merged commit e6d0107 into 3.9Jan 4, 2021
@JulienPalard
JulienPalard deleted the revert-23827-backport-dcc997c-3.9 branch January 4, 2021 16:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st11st1Awaiting requested review from 1st11st1 is a code owner
@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner
@ethanfurmanethanfurmanAwaiting requested review from ethanfurman
1 more reviewer
@andresdelfinoandresdelfinoandresdelfino approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JulienPalard@andresdelfino@the-knights-who-say-ni@bedevere-bot