Skip to content

bpo-1635741: Adapt _multibytecodec to multi-phase initialization - #24095

Merged
vstinner merged 17 commits into
python:masterfrom
erlend-aasland:multibytecodec-module-state
Jan 4, 2021
Merged

bpo-1635741: Adapt _multibytecodec to multi-phase initialization#24095
vstinner merged 17 commits into
python:masterfrom
erlend-aasland:multibytecodec-module-state

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jan 4, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor
  • Establish module state
  • Convert types to heap types and add them to module state
  • Add multi-phase init support

https://bugs.python.org/issue1635741

@erlend-aasland

erlend-aasland commented Jan 4, 2021

Copy link
Copy Markdown
ContributorAuthor

@corona10 or @shihai1991, would one of you mind reviewing this PR?

shihai1991
shihai1991 reviewed Jan 4, 2021
View reviewed changes

@shihai1991shihai1991 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just nitpicks in here. And no refleaks when I run ./python -m test test_multibytecodec -R 3:3 -vv.

Comment threadMisc/NEWS.d/next/Library/2021-01-04-15-05-40.bpo-1635741.EOCfZY.rst Outdated
Comment threadModules/cjkcodecs/multibytecodec.c Outdated
vstinner
vstinner reviewed Jan 4, 2021
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2021-01-04-15-05-40.bpo-1635741.EOCfZY.rst Outdated
Comment threadModules/cjkcodecs/multibytecodec.c Outdated
Comment threadModules/cjkcodecs/multibytecodec.c Outdated
Comment threadModules/cjkcodecs/multibytecodec.c Outdated
Comment threadModules/cjkcodecs/multibytecodec.c
@erlend-aasland
erlend-aaslandforce-pushed the multibytecodec-module-state branch from 90deaf4 to e8b3021CompareJanuary 4, 2021 20:55
@erlend-aasland

erlend-aasland commented Jan 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks for your review, @vstinner. PTAL.

vstinner
vstinner reviewed Jan 4, 2021
View reviewed changes
Comment threadModules/cjkcodecs/multibytecodec.c Outdated
Erlend Egeberg Aaslandand others added 2 commits January 4, 2021 22:08
Erlend Egeberg Aasland@vstinner
Rename __methods to _multibytecodec_methods for consistency
18c1829
Co-authored-by: Victor Stinner <vstinner@python.org>
Erlend E. Aasland
Fix rename
bf3da94
@vstinner
vstinner merged commit 0b858cd into python:masterJan 4, 2021
@vstinner

vstinner commented Jan 4, 2021

Copy link
Copy Markdown
Member

Merged, thanks.

@erlend-aasland
erlend-aasland deleted the multibytecodec-module-state branch January 4, 2021 21:37
@erlend-aasland

erlend-aasland commented Jan 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Merged, thanks.

Great, thanks for a thorough review!

@neoneneneonene mentioned this pull request Jan 8, 2021
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland@adorilson
bpo-1635741: Convert _multibytecodec to multi-phase init (pythonGH-24095
42e5f6b
)
Convert the _multibytecodec extension module (CJK codecs) to multi-phase
initialization (PEP 489).
@kylotankylotanmannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10corona10Awaiting requested review from corona10
@encukouencukouAwaiting requested review from encukou
@shihai1991shihai1991Awaiting requested review from shihai1991
@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland@vstinner@shihai1991@the-knights-who-say-ni@bedevere-bot