Skip to content

bpo-41798: Allocate the datetime.datetime_CAPI on the heap memory. - #24096

Merged
vstinner merged 4 commits into
python:masterfrom
shihai1991:bpo_41798_3
Jan 6, 2021
Merged

bpo-41798: Allocate the datetime.datetime_CAPI on the heap memory.#24096
vstinner merged 4 commits into
python:masterfrom
shihai1991:bpo_41798_3

Conversation

@shihai1991

@shihai1991shihai1991 commented Jan 4, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

vstinner
vstinner reviewed Jan 4, 2021
View reviewed changes
Comment threadModules/_datetimemodule.c Outdated
Comment threadModules/_datetimemodule.c Outdated
Comment threadModules/_datetimemodule.c Outdated
Comment threadModules/_datetimemodule.c Outdated
encukou
encukou reviewed Jan 5, 2021
View reviewed changes
Comment threadModules/_datetimemodule.c Outdated
Comment threadModules/_datetimemodule.c Outdated
vstinner
vstinner reviewed Jan 6, 2021
View reviewed changes
Comment threadModules/_datetimemodule.c
Comment threadModules/_datetimemodule.c Outdated
vstinner
vstinner approved these changes Jan 6, 2021
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The updated patch looks simpler and better :-)

@vstinner
vstinner merged commit 1ab0459 into python:masterJan 6, 2021
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@shihai1991@adorilson
bpo-41798: Allocate the _datetime.datetime_CAPI on the heap memory (p…
d958cab
…ythonGH-24096)
@fuzzardfuzzard mentioned this pull request Apr 1, 2021
Closed
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukouencukouencukou left review comments
@vstinnervstinnervstinner approved these changes
@abalkinabalkinAwaiting requested review from abalkin
@pgansslepganssleAwaiting requested review from pganssle

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shihai1991@vstinner@encukou@the-knights-who-say-ni@bedevere-bot