Skip to content

bpo-40956: fix sqlite3.Cursor.fetchmany() default value - #24214

Merged
berkerpeksag merged 8 commits into
python:masterfrom
erlend-aasland:sqlite-fix-cursor-ac
Jan 13, 2021
Merged

bpo-40956: fix sqlite3.Cursor.fetchmany() default value#24214
berkerpeksag merged 8 commits into
python:masterfrom
erlend-aasland:sqlite-fix-cursor-ac

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jan 13, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aasland

erlend-aasland commented Jan 13, 2021

Copy link
Copy Markdown
ContributorAuthor

skip news

@erlend-aasland

erlend-aasland commented Jan 13, 2021

Copy link
Copy Markdown
ContributorAuthor

@berkerpeksag, would you mind reviewing this?

@erlend-aaslanderlend-aasland changed the title bpo-40956: fix Cursor.fetchmany() default valuebpo-40956: fix sqlite3.Cursor.fetchmany() default valueJan 13, 2021
berkerpeksag
berkerpeksag requested changes Jan 13, 2021
View reviewed changes
Comment threadModules/_sqlite/clinic/cursor.c.h Outdated
@bedevere-bot

bedevere-bot commented Jan 13, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@erlend-aasland
erlend-aasland marked this pull request as draft January 13, 2021 21:09
@erlend-aasland

erlend-aasland commented Jan 13, 2021

Copy link
Copy Markdown
ContributorAuthor

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jan 13, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

@erlend-aasland
erlend-aasland marked this pull request as ready for review January 13, 2021 22:12
@berkerpeksag
berkerpeksag merged commit a330365 into python:masterJan 13, 2021
@erlend-aasland
erlend-aasland deleted the sqlite-fix-cursor-ac branch January 13, 2021 23:26
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland@adorilson
bpo-40956: Fix sqlite3.Cursor.fetchmany() default value (pythonGH-24214)
fedd528
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksagberkerpeksagberkerpeksag approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@bedevere-bot@berkerpeksag@the-knights-who-say-ni