Skip to content

bpo-41824: Add versionadded for typing.ForwardRef docs - #24224

Merged
gvanrossum merged 2 commits into
python:masterfrom
Fidget-Spinner:patch-1
Feb 9, 2021
Merged

bpo-41824: Add versionadded for typing.ForwardRef docs#24224
gvanrossum merged 2 commits into
python:masterfrom
Fidget-Spinner:patch-1

Conversation

@Fidget-Spinner

@Fidget-SpinnerFidget-Spinner commented Jan 15, 2021•
edited
Loading

Copy link
Copy Markdown
Member

typing.ForwardRef officially became part of the documented public API in GH-14216 (19 Jun 2019). I'm interpolating a little and guessing it landed in Python 3.7.4 according to PEP 537's schedule https://www.python.org/dev/peps/pep-0537/#id3.

https://bugs.python.org/issue41824

@bedevere-botbedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 15, 2021
@Fidget-Spinner

Fidget-Spinner commented Jan 15, 2021

Copy link
Copy Markdown
MemberAuthor

I'm guessing this should be backported to 3.9 and 3.8 (along with skip news)?

@gvanrossum
gvanrossum merged commit da21f7b into python:masterFeb 9, 2021
@bedevere-bot

bedevere-bot commented Feb 9, 2021

Copy link
Copy Markdown

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@Fidget-Spinner

Fidget-Spinner commented Feb 9, 2021

Copy link
Copy Markdown
MemberAuthor

@gvanrossum Thanks Guido! Should this be backported to 3.9/3.8 too?

@gvanrossum

gvanrossum commented Feb 9, 2021

Copy link
Copy Markdown
Member

@gvanrossum Thanks Guido! Should this be backported to 3.9/3.8 too?

Sure.

@Fidget-Spinner

Fidget-Spinner commented Feb 9, 2021

Copy link
Copy Markdown
MemberAuthor

@gvanrossum Thanks Guido! Should this be backported to 3.9/3.8 too?

Sure.

Sorry to trouble, can you add the labels for them please? I don't have permissions to. Though I'm not sure if the bot will pick it up if the label is applied after the PR is merged rather than before. Either way I'm fine with manually backporting them too.

@miss-islington

miss-islington commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

Thanks @Fidget-Spinner for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

Thanks @Fidget-Spinner for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@gvanrossum

gvanrossum commented Feb 9, 2021

Copy link
Copy Markdown
Member

Looks like the bot picked it up!

@miss-islington

miss-islington commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

Sorry, @Fidget-Spinner and @gvanrossum, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker da21f7b6e1fd5bd3e78931a06c5eb694f6335233 3.8

@miss-islington

miss-islington commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

Sorry @Fidget-Spinner and @gvanrossum, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker da21f7b6e1fd5bd3e78931a06c5eb694f6335233 3.9

@Fidget-Spinner

Fidget-Spinner commented Feb 9, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Aww I guess I should've done it manually from the start then. Thanks for the help anyways!

@bedevere-bot

bedevere-bot commented Feb 9, 2021

Copy link
Copy Markdown

GH-24493 is a backport of this pull request to the 3.9 branch.

Fidget-Spinner added a commit to Fidget-Spinner/cpython that referenced this pull request Feb 9, 2021
@Fidget-Spinner
[3.8] bpo-41824: Add versionadded for typing.ForwardRef docs (python#…
ca1f14b
…24224)
@bedevere-bot

bedevere-bot commented Feb 9, 2021

Copy link
Copy Markdown

GH-24494 is a backport of this pull request to the 3.8 branch.

gvanrossum pushed a commit that referenced this pull request Feb 9, 2021
@Fidget-Spinner
bpo-41824: Add versionadded for typing.ForwardRef docs (#24224) (#24493)
917eca7
gvanrossum pushed a commit that referenced this pull request Feb 9, 2021
@Fidget-Spinner
[3.8]bpo-41824: Add versionadded for typing.ForwardRef docs (#24224) (…
c8a48c6
…#24494)
@Fidget-Spinner
Fidget-Spinner deleted the patch-1 branch February 9, 2021 16:59
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@Fidget-Spinner@adorilson
bpo-41824: Add versionadded for typing.ForwardRef docs (python#24224)
6f8e162
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes
@ilevkivskyiilevkivskyiAwaiting requested review from ilevkivskyi

Assignees

@gvanrossumgvanrossum

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Fidget-Spinner@bedevere-bot@gvanrossum@miss-islington@tirkarthi@the-knights-who-say-ni