Skip to content

bpo-40077: Convert zoneinfo type to heap type - #24481

Closed
erlend-aasland wants to merge 4 commits into
python:masterfrom
erlend-aasland:zoneinfo-heap-type
Closed

bpo-40077: Convert zoneinfo type to heap type#24481
erlend-aasland wants to merge 4 commits into
python:masterfrom
erlend-aasland:zoneinfo-heap-type

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Feb 8, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aasland

erlend-aasland commented Feb 8, 2021

Copy link
Copy Markdown
ContributorAuthor

cc. @corona10@vstinner

FYI: _zoneinfo is already multi-phase init.

@pablogsal

pablogsal commented Feb 8, 2021

Copy link
Copy Markdown
Member

I would recommend waiting for #24065 (comment) before continuing with heap type changes

@erlend-aasland

erlend-aasland commented Feb 8, 2021

Copy link
Copy Markdown
ContributorAuthor

I would recommend waiting for #24065 (comment) before continuing with heap type changes

No problem :)

shihai1991
shihai1991 reviewed Feb 8, 2021
View reviewed changes
Comment threadModules/_zoneinfo.c Outdated
Comment threadModules/_zoneinfo.c Outdated
@github-actions

github-actionsBot commented Mar 11, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Mar 11, 2021
@erlend-aasland

erlend-aasland commented Oct 22, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
ContributorAuthor

I would recommend waiting for #24065 (comment) before continuing with heap type changes

BTW, I just skimmed through PEP 630 Isolating Extension Modules again, and I started wondering why it is not enough? It is well written, accepted/active, and it explains the rationale of heap types well, and it even advocates that the standard library should be an "early adopter". Has there been an official statement from the SC regarding halting bpo-40077? Just wondering :)

@erlend-aasland

erlend-aasland commented Jun 27, 2022

Copy link
Copy Markdown
ContributorAuthor

FYI, PEP-687 was just accepted.

@corona10corona10 mentioned this pull request Jun 27, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shihai1991shihai1991shihai1991 left review comments

Assignees

No one assigned

Labels

awaiting reviewstaleStale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland@pablogsal@shihai1991@the-knights-who-say-ni@bedevere-bot