Skip to content

bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor - #24540

Merged
serhiy-storchaka merged 6 commits into
python:mainfrom
illia-v:bpo-43234
Jul 1, 2021
Merged

bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor#24540
serhiy-storchaka merged 6 commits into
python:mainfrom
illia-v:bpo-43234

Conversation

@illia-v

@illia-villia-v commented Feb 15, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Mar 18, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Mar 18, 2021
serhiy-storchaka
serhiy-storchaka requested changes Jun 28, 2021
View reviewed changes
Comment threadDoc/library/asyncio-eventloop.rst Outdated
Comment threadDoc/library/asyncio-eventloop.rst Outdated
Comment threadDoc/whatsnew/3.10.rst Outdated
Comment threadLib/asyncio/base_events.py Outdated
@bedevere-bot

bedevere-bot commented Jun 28, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@serhiy-storchakaserhiy-storchaka removed the stale Stale PR or inactive for long period of time. label Jun 28, 2021
illia-vand others added 4 commits June 29, 2021 17:19
@illia-v
Merge branch 'main' into bpo-43234
d693afa
@illia-v@serhiy-storchaka
Apply documentation suggestions
3df77a8
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@illia-v@serhiy-storchaka
Update a type of the used error
a78287f
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@illia-v
Move a change note to the 3.11 what's new file
8eb3658
@illia-v

illia-v commented Jun 29, 2021

Copy link
Copy Markdown
ContributorAuthor

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jun 29, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

@illia-v

illia-v commented Jun 29, 2021

Copy link
Copy Markdown
ContributorAuthor

@serhiy-storchaka if you have a chance, please take a look at #24525 too

serhiy-storchaka
serhiy-storchaka reviewed Jun 30, 2021
View reviewed changes
Comment threadLib/test/test_asyncio/test_base_events.py Outdated
Comment threadLib/test/test_asyncio/test_base_events.py Outdated
@illia-v@serhiy-storchaka
Update a related test
d5934a0
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@illia-v

illia-v commented Jun 30, 2021

Copy link
Copy Markdown
ContributorAuthor

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jun 30, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

serhiy-storchaka
serhiy-storchaka approved these changes Jul 1, 2021
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka
serhiy-storchaka merged commit ddd5f36 into python:mainJul 1, 2021
eirrgang added a commit to eirrgang/cpython that referenced this pull request Jun 9, 2023
@eirrgang
Remove references to ProcessPoolExecutor from asyncio-dev.rst
0b3e1b6
ddd5f36 updated asyncio-eventloop.rst, but overlooked other references to using non-ThreadPoolExecutors with `run_in_executor()`.
Ref bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor (pythonGH-24540)
@eirrgangeirrgang mentioned this pull request Jun 9, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes
@1st11st1Awaiting requested review from 1st11st1 is a code owner
@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@illia-v@bedevere-bot@serhiy-storchaka@the-knights-who-say-ni