Skip to content

bpo-35134: Move Include/{pyarena.h,pyctype.h} to Include/cpython - #24550

Merged
vstinner merged 2 commits into
python:masterfrom
nw0:bpo-35134-1
Feb 17, 2021
Merged

bpo-35134: Move Include/{pyarena.h,pyctype.h} to Include/cpython#24550
vstinner merged 2 commits into
python:masterfrom
nw0:bpo-35134-1

Conversation

@nw0

@nw0nw0 commented Feb 16, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Move non-limited C API headers pyarena.h, pyctype.h into
Include/cpython.

In the same vein as previous PRs by @vstinner.

https://bugs.python.org/issue35134

@nw0
Move Include/{pyarena.h,pyctype.h} to Include/cpython
ba11be5
Move non-limited C API headers pyarena.h, pyctype.h into
Include/cpython.
@nw0
nw0 requested review from a team, lysnikolaou and pablogsal as code ownersFebruary 16, 2021 14:13
@vstinner

vstinner commented Feb 16, 2021

Copy link
Copy Markdown
Member

Can you please add a NEWS entry in the C API to mention that pytime.h, pyarena.h and pyctype.h headers were moved into the cpython/ directory and must not be included directly: they are already included by Python.h.

You can add a :ref:`Include Files <api-includes>` link to https://docs.python.org/dev/c-api/intro.html#include-files.

@nw0

nw0 commented Feb 17, 2021

Copy link
Copy Markdown
ContributorAuthor

Can you please add a NEWS entry in the C API to mention that pytime.h, pyarena.h and pyctype.h headers were moved into the cpython/ directory and must not be included directly: they are already included by Python.h.

You can add a :ref:`Include Files <api-includes>` link to https://docs.python.org/dev/c-api/intro.html#include-files.

Updated. Thanks for your review!

@vstinner
vstinner merged commit 366dc3a into python:masterFeb 17, 2021
@vstinner

vstinner commented Feb 17, 2021

Copy link
Copy Markdown
Member

Merged, thanks!

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@nw0@adorilson
bpo-35134: Move Include/{pyarena.h,pyctype.h} to Include/cpython/ (py…
3953750
…thonGH-24550)
Move non-limited C API headers pyarena.h and pyctype.h
into Include/cpython/ directory.
@vstinnervstinner mentioned this pull request Apr 10, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaou
@pablogsalpablogsalAwaiting requested review from pablogsal
@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nw0@vstinner@the-knights-who-say-ni@bedevere-bot