Uh oh!
There was an error while loading. Please reload this page.
bpo-43316: gzip: CLI uses non-zero return code on error. - #24647
Merged
Conversation
Exit code is now 1 instead of 0. A message is printed to stderr instead of stdout. This is the proper behaviour for a tool that can be used in scripts.
miss-islington
commented
Feb 25, 2021
Contributor
Thanks @rhpvorderman for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 25, 2021
) Exit code is now 1 instead of 0. A message is printed to stderr instead of stdout. This is the proper behaviour for a tool that can be used in scripts. (cherry picked from commit cc3df63) Co-authored-by: Ruben Vorderman <r.h.p.vorderman@lumc.nl>
bedevere-bot
commented
Feb 25, 2021
GH-24648 is a backport of this pull request to the 3.9 branch. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 25, 2021
) Exit code is now 1 instead of 0. A message is printed to stderr instead of stdout. This is the proper behaviour for a tool that can be used in scripts. (cherry picked from commit cc3df63) Co-authored-by: Ruben Vorderman <r.h.p.vorderman@lumc.nl>
bedevere-bot
commented
Feb 25, 2021
GH-24649 is a backport of this pull request to the 3.8 branch. |
miss-islington added a commit
that referenced
this pull request
Feb 25, 2021
Exit code is now 1 instead of 0. A message is printed to stderr instead of stdout. This is the proper behaviour for a tool that can be used in scripts. (cherry picked from commit cc3df63) Co-authored-by: Ruben Vorderman <r.h.p.vorderman@lumc.nl>
rhpvorderman
commented
Feb 25, 2021
ContributorAuthor
Thanks @methane ! |
merwok
reviewed
Feb 25, 2021
| if arg[-3:] != ".gz": | ||
| print("filename doesn't end in .gz:", repr(arg)) | ||
| continue | ||
| sys.exit("filename doesn't end in .gz:", repr(arg)) |
Member
There was a problem hiding this comment.
Shouldn’t this use string concatenation or f-string to pass one argument to sys.exit?
Signature is sys.exit(status=None)
Member
There was a problem hiding this comment.
You are right! We can not pass two strings to sys.exit().
I don't know why this passed the test.
Member
There was a problem hiding this comment.
Now I got it. The stderr is:
Traceback (most recent call last):
(snip)
File "/Users/inada-n/work/python/cpython/Lib/gzip.py", line 586, in main
sys.exit("filename doesn't end in .gz:", repr(arg))
TypeError: exit expected at most 1 argument, got 2
And it passes the test self.assertIn(b"filename doesn't end in .gz:", err).
methane pushed a commit
that referenced
this pull request
Feb 26, 2021
Exit code is now 1 instead of 0. A message is printed to stderr instead of stdout. This is the proper behaviour for a tool that can be used in scripts. (cherry picked from commit cc3df63) Co-authored-by: Ruben Vorderman <r.h.p.vorderman@lumc.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exit code is now 1 instead of 0. A message is printed to stderr instead of stdout. This is
the proper behaviour for a tool that can be used in scripts.
In my opinion this change should be backported to all currently supported versions of python. Exiting with 0 upon error is not acceptable behaviour for a tool. Luckily, I think the backport will be quite easy and I am happy to do it.
https://bugs.python.org/issue43316