Skip to content

bpo-43612: Add wbits parameter to zlib.compress - #25011

Closed
rhpvorderman wants to merge 10 commits into
python:mainfrom
rhpvorderman:bpo-43612
Closed

bpo-43612: Add wbits parameter to zlib.compress#25011
rhpvorderman wants to merge 10 commits into
python:mainfrom
rhpvorderman:bpo-43612

Conversation

@rhpvorderman

@rhpvordermanrhpvorderman commented Mar 24, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This allows users to compress raw deflate blocks without zlib headers and trailers in one go. Without needing to use zlib.compressobj. Also this allows users to do zlib.compress(data, 1, wbits=31) which is much faster than gzip.compress(data, 1).

https://bugs.python.org/issue43612

@github-actions

github-actionsBot commented Apr 24, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Apr 24, 2021
ZackerySpytz
ZackerySpytz reviewed May 31, 2021
View reviewed changes
Comment threadDoc/library/zlib.rst Outdated
Comment threadDoc/library/zlib.rst Outdated
Comment threadDoc/library/zlib.rst Outdated
Comment threadDoc/library/zlib.rst Outdated
Comment threadModules/zlibmodule.c Outdated
Comment threadMisc/NEWS.d/next/Library/2021-03-24-09-40-02.bpo-43612.vMGZ4y.rst Outdated
@rhpvorderman

rhpvorderman commented Jun 1, 2021

Copy link
Copy Markdown
ContributorAuthor

@ZackerySpytz Thank you for the review! I addressed your comments.

@github-actionsgithub-actionsBot removed the stale Stale PR or inactive for long period of time. label Jun 2, 2021
@rhpvordermanrhpvorderman mentioned this pull request Aug 25, 2021
Merged
@rhpvorderman

rhpvorderman commented Aug 25, 2021

Copy link
Copy Markdown
ContributorAuthor

Changes incorporated in #27941

@rhpvordermanrhpvorderman mentioned this pull request Oct 17, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ZackerySpytzZackerySpytzZackerySpytz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rhpvorderman@ZackerySpytz@the-knights-who-say-ni@bedevere-bot