Uh oh!
There was an error while loading. Please reload this page.
bpo-43651: Fix EncodingWarning in test_io - #25097
Conversation
Uh oh!
There was an error while loading. Please reload this page.
methane
commented
Mar 31, 2021
This PR can be simplified after #25103 is merged. |
methane
commented
Mar 31, 2021
#25103 did not help OpenWrapper(). I don't think we should allow |
| with self.open(os_helper.TESTFN, mode) as fp: | ||
| self.assertRaises(exc, fp.read) | ||
| self.assertRaises(exc, fp.readline) | ||
| with self.open(os_helper.TESTFN, "w", encoding="ascii") as fp: |
There was a problem hiding this comment.
I would prefer to replace all "ascii" with "utf-8". Come on, ASCII is now legacy!
bedevere-bot
commented
Apr 1, 2021
|
https://bugs.python.org/issue43651