Uh oh!
There was an error while loading. Please reload this page.
bpo-41111: Build limited C API without Py_TRACE_REFS macro. - #25180
Merged
Conversation
vstinner
reviewed
Apr 4, 2021
| # Limited C API | ||
| self.add(Extension('xxlimited', ['xxlimited.c'])) | ||
| self.add(Extension('xxlimited_35', ['xxlimited_35.c'])) | ||
| # Build limited C API without Py_TRACE_REFS macro |
Member
There was a problem hiding this comment.
This comment is wrong. You should say that the limited C API is not compatible with the Py_TRACE_REFS macro.
vstinner
commented
Apr 6, 2021
Member
Thanks, I merged your fix. Without this fix, xxlimited failed to build on the AMD64 Arch Linux TraceRefs 3.x buildbot. Example: https://buildbot.python.org/all/#/builders/484/builds/525 But it's not treated as an error: the compilation is displayed as a success. Moreover, test_xxlimited is simply skipped if xxlimited is missing. This change should fix it. |
shihai1991
commented
Apr 6, 2021
MemberAuthor
Thanks Victor for your review & merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41111