Uh oh!
There was an error while loading. Please reload this page.
bpo-43762: Add audit events for loading of sqlite3 extensions - #25246
Conversation
erlend-aasland
commented
Apr 7, 2021
cc. @tiran |
fcbf3a3 to
36f075fCompareerlend-aasland
commented
Apr 20, 2021
zooba
left a comment
There was a problem hiding this comment.
Couple of minor tweaks, mainly for readability/ease of use.
I wonder if it's worth returning the connection object when it's created (through a new event in module.c) and then reference it in these events? That can then correlate these (and other) events with the file - we do this already for sockets.
After some thought, I think it's probably not worth it for these ones. The important information is in the extension being loaded, and it doesn't really relate to the connection at all. However, if we wanted to add it later, we couldn't. So might be worth doing now?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
20dda83 to
ea0116cCompareCo-authored-by: Steve Dower <steve.dower@microsoft.com>
ea0116c to
dd2ffdeCompareerlend-aasland
commented
Apr 24, 2021
FYI, rebased onto |
zooba
left a comment
There was a problem hiding this comment.
Approved with the doc update suggestions
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
erlend-aasland
commented
Apr 26, 2021
Thanks for reviewing! BTW, I used |
https://bugs.python.org/issue43762