Skip to content

bpo-39899: ntpath.expanduser(): don't check the basename of the directory matches the username if we're requesting the current user's home directory - #25277

Merged
zooba merged 1 commit into
python:masterfrom
barneygale:bpo-39899-pathlib-expanduser-fix-same-user
Apr 9, 2021
Merged

bpo-39899: ntpath.expanduser(): don't check the basename of the directory matches the username if we're requesting the current user's home directory#25277
zooba merged 1 commit into
python:masterfrom
barneygale:bpo-39899-pathlib-expanduser-fix-same-user

Conversation

@barneygale

@barneygalebarneygale commented Apr 8, 2021

Copy link
Copy Markdown
Contributor

Eryk Sun spotted that the implementation in #18841 shouldn't perform the basename check if we're querying for the current user's home directory via ~user.

https://bugs.python.org/issue39899

@barneygalebarneygale changed the title ntpath.expanduser(): don't check the basename of the directory matches the username if we're requesting the current user's home directorybpo-39899: ntpath.expanduser(): don't check the basename of the directory matches the username if we're requesting the current user's home directoryApr 8, 2021
…s the username if we're requesting the current user's home directory
@barneygale

Copy link
Copy Markdown
ContributorAuthor

@zooba flagging for review, if you have a mo? This is a follow-up to #18841 that fixes a mistake. Thank you!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@barneygale@zooba@the-knights-who-say-ni@bedevere-bot