Skip to content

bpo-38530: Clean exceptions if dir() fails when making suggestions for AttributeError - #25408

Merged
pablogsal merged 3 commits into
python:masterfrom
pablogsal:bpo-38530
Apr 14, 2021
Merged

bpo-38530: Clean exceptions if dir() fails when making suggestions for AttributeError#25408
pablogsal merged 3 commits into
python:masterfrom
pablogsal:bpo-38530

Conversation

@pablogsal

@pablogsalpablogsal commented Apr 14, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Caught by the mighty eye of @dutc!

https://bugs.python.org/issue38530

vstinner
vstinner reviewed Apr 14, 2021
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I would prefer to clear the exception in the function calling _Py_Offer_Suggestions().

Comment threadLib/test/test_exceptions.py Outdated
@pablogsal

pablogsal commented Apr 14, 2021

Copy link
Copy Markdown
MemberAuthor

Honestly, I would prefer to clear the exception in the function calling _Py_Offer_Suggestions().

Ok, we can do that

@pablogsal
pablogsal requested a review from vstinnerApril 14, 2021 15:08
ammaraskar
ammaraskar reviewed Apr 14, 2021
View reviewed changes
Comment threadLib/test/test_exceptions.py
vstinner
vstinner approved these changes Apr 14, 2021
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pablogsal
pablogsal merged commit e07f4ab into python:masterApr 14, 2021
@pablogsal
pablogsal deleted the bpo-38530 branch April 14, 2021 17:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ammaraskarammaraskarammaraskar left review comments
@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal@vstinner@ammaraskar@the-knights-who-say-ni@bedevere-bot