Uh oh!
There was an error while loading. Please reload this page.
added exception groups - #25430
Conversation
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Unfortunately we can't express here that ExceptionGroup subclasses BaseExceptionGroup as well.
There was a problem hiding this comment.
There seems to be an unused feature that interprets whatever is in "(..)" as a platform name and then ignores any exception where the platform is not the current platform (so it won't break the test but will weaken it).
But "[...]" seems ok - anything in them appears to be ignored, and when I changed ExceptionGroup to something invalid the test failed.
cpython/Lib/test/test_baseexception.py
Line 49 in 8bbfeb3
Uh oh!
There was an error while loading. Please reload this page.
gvanrossum
left a comment
There was a problem hiding this comment.
Is this what we will merge once the PEP is accepted?
(Note that the master -> main rename will happen at that time too. But supposedly PSs will be automatically adjusted. We’ll see.)
Uh oh!
There was an error while loading. Please reload this page.
gvanrossum
commented
Apr 16, 2021
Probably mark as Draft? |
bbedd10 to
40c3cd0Compare
iritkatriel
left a comment
There was a problem hiding this comment.
Is this what we will merge once the PEP is accepted?
That's the idea. The branch of the other PR is very old and compile.c/eval.c changed beyond what can be fixed with a rebase. So I started from scratch on a recent cut of master. Marked as draft for now.
There was a problem hiding this comment.
There seems to be an unused feature that interprets whatever is in "(..)" as a platform name and then ignores any exception where the platform is not the current platform (so it won't break the test but will weaken it).
But "[...]" seems ok - anything in them appears to be ignored, and when I changed ExceptionGroup to something invalid the test failed.
cpython/Lib/test/test_baseexception.py
Line 49 in 8bbfeb3
Uh oh!
There was an error while loading. Please reload this page.
81b6b08 to
cecdf32Comparegvanrossum
commented
May 11, 2021
You should probably merge this on main. |
…ality which is needed for cycle detection and except*'s reraise logic
cecdf32 to
0a9e6b5Compareiritkatriel
commented
May 11, 2021
I rebased and regenerated Python/importlib_external.h |
This PR is stale because it has been open for 30 days with no activity. |
iritkatriel
commented
Sep 26, 2021
Superseded by #28569. |
First step of PEP-654: added Exception Groups (without updating traceback formatting).