Skip to content

bpo-38530: Match exactly AttributeError and NameError when offering suggestions - #25443

Merged
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo-38530-2
Apr 16, 2021
Merged

bpo-38530: Match exactly AttributeError and NameError when offering suggestions#25443
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo-38530-2

Conversation

@pablogsal

@pablogsalpablogsal commented Apr 16, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

isidentical
isidentical reviewed Apr 16, 2021
View reviewed changes
Comment threadLib/test/test_exceptions.py Outdated
vstinner
vstinner approved these changes Apr 16, 2021
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment threadPython/suggestions.c Outdated
vstinner
vstinner reviewed Apr 16, 2021
View reviewed changes
Comment threadPython/suggestions.c Outdated
@pablogsal
pablogsal merged commit 0ad81d4 into python:masterApr 16, 2021
@pablogsal
pablogsal deleted the bpo-38530-2 branch April 16, 2021 16:12
@tirkarthitirkarthi mentioned this pull request Jan 21, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@isidenticalisidenticalisidentical approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal@vstinner@isidentical@the-knights-who-say-ni@bedevere-bot