Skip to content

bpo-38530: Properly extend UnboundLocalError from NameError - #25444

Merged
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo-38530-3
Apr 16, 2021
Merged

bpo-38530: Properly extend UnboundLocalError from NameError#25444
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo-38530-3

Conversation

@pablogsal

@pablogsalpablogsal commented Apr 16, 2021

Copy link
Copy Markdown
Member

@isidenticalisidentical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issubclass(UnboundLocalError, NameError) already returns True. What is the effect of this change?

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ah, this change is needed because NameError now defines its init, dealloc, traverse, etc. methods. Ok, I get it ;-)

@pablogsal
pablogsal merged commit 3b82cae into python:masterApr 16, 2021
@pablogsal
pablogsal deleted the bpo-38530-3 branch April 16, 2021 15:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal@vstinner@isidentical@the-knights-who-say-ni@bedevere-bot