Skip to content

bpo-43908: Add Py_TPFLAGS_IMMUTABLETYPE flag - #25520

Merged
vstinner merged 10 commits into
python:masterfrom
erlend-aasland:immutable-types
Apr 28, 2021
Merged

bpo-43908: Add Py_TPFLAGS_IMMUTABLETYPE flag#25520
vstinner merged 10 commits into
python:masterfrom
erlend-aasland:immutable-types

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Apr 22, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aasland
erlend-aasland marked this pull request as ready for review April 22, 2021 11:50
gvanrossum
gvanrossum reviewed Apr 24, 2021
View reviewed changes
Comment threadDoc/c-api/typeobj.rst Outdated
shreyanavigyan
shreyanavigyan reviewed Apr 26, 2021
View reviewed changes
Comment threadDoc/c-api/typeobj.rst Outdated
@erlend-aasland
erlend-aasland marked this pull request as draft April 26, 2021 08:22
@erlend-aaslanderlend-aasland changed the title bpo-43908: Add Py_TPFLAGS_IMMUTABLE flag and use it in arraymodulebpo-43908: Add Py_TPFLAGS_IMMUTABLE flagApr 26, 2021
@erlend-aasland
erlend-aasland marked this pull request as ready for review April 26, 2021 18:50
@erlend-aasland

erlend-aasland commented Apr 26, 2021

Copy link
Copy Markdown
ContributorAuthor

cc. @pablogsal@vstinner@serhiy-storchaka@tiran

@erlend-aaslanderlend-aasland changed the title bpo-43908: Add Py_TPFLAGS_IMMUTABLE flagbpo-43908: Add Py_TPFLAGS_IMMUTABLETYPE flagApr 26, 2021
pablogsal
pablogsal reviewed Apr 26, 2021
View reviewed changes
Comment threadObjects/typeobject.c
@erlend-aasland

erlend-aasland commented Apr 27, 2021

Copy link
Copy Markdown
ContributorAuthor

@pablogsal are you ok with the PR as it is?

vstinner
vstinner reviewed Apr 28, 2021
View reviewed changes
Comment threadDoc/c-api/typeobj.rst Outdated
Comment threadDoc/c-api/typeobj.rst Outdated
Comment threadInclude/object.h Outdated
Comment threadObjects/typeobject.c
shreyanavigyan
shreyanavigyan reviewed Apr 28, 2021
View reviewed changes
Comment threadMisc/NEWS.d/next/Core and Builtins/2021-04-22-10-46-40.bpo-43908.Co3YhZ.rst Outdated
Erlend Egeberg Aaslandand others added 3 commits April 28, 2021 17:16
Erlend Egeberg Aasland@vstinner
Improve docs
025af5b
Co-authored-by: Victor Stinner <vstinner@python.org>
Erlend Egeberg Aasland@vstinner
Improve docs
0e8c709
Co-authored-by: Victor Stinner <vstinner@python.org>
Erlend Egeberg Aasland@vstinner
Improve comment
8c79eae
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
vstinner reviewed Apr 28, 2021
View reviewed changes
Comment threadMisc/NEWS.d/next/Core and Builtins/2021-04-22-10-46-40.bpo-43908.Co3YhZ.rst Outdated
Erlend Egeberg Aaslandand others added 3 commits April 28, 2021 17:27
vstinner
vstinner reviewed Apr 28, 2021
View reviewed changes
Comment threadDoc/c-api/typeobj.rst Outdated
Comment threadMisc/NEWS.d/next/C API/2021-04-22-10-46-40.bpo-43908.Co3YhZ.rst Outdated
Comment threadObjects/typeobject.c
Erlend Egeberg Aaslandand others added 2 commits April 28, 2021 17:37
Erlend Egeberg Aasland@vstinner
Spelling fix
3032d3b
Co-authored-by: Victor Stinner <vstinner@python.org>
Erlend Egeberg Aasland
Improve NEWS wording
edf4097
vstinner
vstinner approved these changes Apr 28, 2021
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

IMO it was important to mention "type attributes cannot be set nor deleted" to explain what "immutable" means. I stop nitpicking, let's move on to add this flag to types recently converted to heap types.

@erlend-aasland

erlend-aasland commented Apr 28, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks, @vstinner! I appreciate the doc/comment nitpicking; you're improved the PR considerably.

@vstinner

vstinner commented Apr 28, 2021

Copy link
Copy Markdown
Member

@erlend-aasland: Travis CI failed:

Fixing docs whitespace ... 1 file:
Doc/c-api/typeobj.rst
Please fix the 1 file(s) with whitespace issues
(on UNIX you can run `make patchcheck` to make the fixes)

shreyanavigyan
shreyanavigyan reviewed Apr 28, 2021
View reviewed changes
Comment threadDoc/c-api/typeobj.rst
@erlend-aasland

erlend-aasland commented Apr 28, 2021

Copy link
Copy Markdown
ContributorAuthor

@erlend-aasland: Travis CI failed:

Oops, I'll fix it. I normally do make html in the Doc directory to make sure I've got the reST markup right.

@erlend-aasland

erlend-aasland commented Apr 28, 2021

Copy link
Copy Markdown
ContributorAuthor

FYI, unrelated random ssl test failure on the macOS CI, @vstinner.

@vstinner
vstinner merged commit 3b52c8d into python:masterApr 28, 2021
@vstinner

vstinner commented Apr 28, 2021

Copy link
Copy Markdown
Member

Merged, thanks.

@erlend-aasland
erlend-aasland deleted the immutable-types branch April 28, 2021 17:08
@pablogsal

pablogsal commented Apr 28, 2021•
edited
Loading

Copy link
Copy Markdown
Member

FYI, unrelated random ssl test failure on the macOS CI, @vstinner.

CC: @tiran This is happening white a lot

@gvanrossumgvanrossum mentioned this pull request May 18, 2022
Closed
@maxbachmannmaxbachmann mentioned this pull request Sep 12, 2022
Merged
da-woods pushed a commit to cython/cython that referenced this pull request Jan 1, 2023
@maxbachmann
Mark extension types as immutable (#5023)
5e5b242
Since python/cpython#25520 types are automatically marked as immutable if they are static.
While we still have the Py_TPFLAGS_HEAPTYPE hack in place we need to manually mark our types as immutable.
It's possible to crash Python by trying to modify mutable static types.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal left review comments
@vstinnervstinnervstinner approved these changes
@markshannonmarkshannonAwaiting requested review from markshannon
@gvanrossumgvanrossumAwaiting requested review from gvanrossum
+1 more reviewer
@shreyanavigyanshreyanavigyanshreyanavigyan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@erlend-aasland@vstinner@pablogsal@gvanrossum@shreyanavigyan@the-knights-who-say-ni@bedevere-bot