Skip to content

bpo-38530: Require 50% similarity in NameError suggestions - #25584

Merged
pablogsal merged 4 commits into
python:masterfrom
sweeneyde:bad_small_suggestions
Apr 27, 2021
Merged

bpo-38530: Require 50% similarity in NameError suggestions#25584
pablogsal merged 4 commits into
python:masterfrom
sweeneyde:bad_small_suggestions

Conversation

@sweeneyde

@sweeneydesweeneyde commented Apr 25, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@isidentical

isidentical commented Apr 25, 2021

Copy link
Copy Markdown
Member

Since this is a new feature in 3.10, I don't think there is a need for a news entry.

@pablogsal

pablogsal commented Apr 25, 2021

Copy link
Copy Markdown
Member

Yeah, could you remove the NEWS entry, @sweeneyde? Otherwise, LGTM

pablogsal
pablogsal reviewed Apr 25, 2021
View reviewed changes
Comment threadLib/test/test_exceptions.py
@sweeneyde
sweeneydeforce-pushed the bad_small_suggestions branch from efba22a to c88fd85CompareApril 25, 2021 03:58
@sweeneyde

sweeneyde commented Apr 25, 2021

Copy link
Copy Markdown
MemberAuthor

A thought: MAX_DISTANCE could be made larger if this change is made.

@pablogsal

pablogsal commented Apr 26, 2021

Copy link
Copy Markdown
Member

A thought: MAX_DISTANCE could be made larger if this change is made.

Indeed, do you have some bandwidth to do some investigation on this? I am referring to what could be a sensible value once we merge this PR.

@pablogsal
pablogsal merged commit 284c52d into python:masterApr 27, 2021
@sweeneyde

sweeneyde commented Apr 27, 2021

Copy link
Copy Markdown
MemberAuthor

A thought: MAX_DISTANCE could be made larger if this change is made.

Indeed, do you have some bandwidth to do some investigation on this? I am referring to what could be a sensible value once we merge this PR.

I can look at some other compilers/interpreters/editors/document processors within the next few days.

@pablogsal

pablogsal commented Apr 27, 2021

Copy link
Copy Markdown
Member

I can look at some other compilers/interpreters/editors/document processors within the next few days.

Thanks, that would be great!

@sweeneyde
sweeneyde deleted the bad_small_suggestions branch December 19, 2021 05:35
@tirkarthitirkarthi mentioned this pull request Jan 21, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal left review comments

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sweeneyde@isidentical@pablogsal@the-knights-who-say-ni@bedevere-bot