Skip to content

bpo-43651: Fix EncodingWarning in tests. - #25655

Merged
methane merged 1 commit into
python:masterfrom
methane:fix-tests
Apr 29, 2021
Merged

bpo-43651: Fix EncodingWarning in tests.#25655
methane merged 1 commit into
python:masterfrom
methane:fix-tests

Conversation

@methane

@methanemethane commented Apr 27, 2021

Copy link
Copy Markdown
Member
  • test_httplib
  • test_httpservers
  • test_logging

https://bugs.python.org/issue43651

* test_httplib
* test_httpservers
* test_logging
@methane
methane requested a review from vsajip as a code ownerApril 27, 2021 08:38
@bedevere-botbedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Apr 27, 2021
@methane
methane merged commit fa51c0c into python:masterApr 29, 2021
@methane
methane deleted the fix-tests branch April 29, 2021 02:34

with self.check_no_resource_warning():
#with self.check_no_resource_warning():
if 1:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the significance of this change?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a mistake. Nice catch.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@methane@vsajip@the-knights-who-say-ni@bedevere-bot