Skip to content

bpo-43916: Remove _disabled_new() function - #25745

Merged
vstinner merged 2 commits into
python:masterfrom
vstinner:remove_disabled_new
Apr 30, 2021
Merged

bpo-43916: Remove _disabled_new() function#25745
vstinner merged 2 commits into
python:masterfrom
vstinner:remove_disabled_new

Conversation

@vstinner

@vstinnervstinner commented Apr 30, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Use the new Py_TPFLAGS_DISALLOW_INSTANTIATION flag on posix and
_hashlib types.

https://bugs.python.org/issue43916

@vstinner
bpo-43916: Remove _disabled_new() function
7c5d116
Use the new Py_TPFLAGS_DISALLOW_INSTANTIATION flag on posix and
_hashlib types.
@vstinner
vstinner requested a review from tiran as a code ownerApril 30, 2021 11:02
@vstinnervstinner mentioned this pull request Apr 30, 2021
Closed
@vstinner

vstinner commented Apr 30, 2021

Copy link
Copy Markdown
MemberAuthor

cc @tiran@erlend-aasland

erlend-aasland
erlend-aasland requested changes Apr 30, 2021
View reviewed changes

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update Lib/test/test_hmac.py too

@vstinner

vstinner commented Apr 30, 2021

Copy link
Copy Markdown
MemberAuthor

You need to update Lib/test/test_hmac.py too

Oops, I missed that part in @tiran's PR #25722.

@vstinner

vstinner commented Apr 30, 2021

Copy link
Copy Markdown
MemberAuthor
  • Windows x86: test_asyncio failed (unrelated).
  • Tests / Ubuntu SSL tests with OpenSSL 1.1.1k: test_asyncio failed (unrelated).
  • Tests / Ubuntu SSL tests with OpenSSL 3.0.0-alpha15: test_asyncio failed (unrelated).

@vstinner
vstinner merged commit 0cad068 into python:masterApr 30, 2021
@vstinner
vstinner deleted the remove_disabled_new branch April 30, 2021 12:06
@pablogsalpablogsal mentioned this pull request May 18, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland requested changes
@tirantirantiran approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner@tiran@erlend-aasland@the-knights-who-say-ni@bedevere-bot