Uh oh!
There was an error while loading. Please reload this page.
bpo-43434: Clean up after GH-25818 - #25823
Merged
Merged
Conversation
erlend-aasland
commented
May 2, 2021
ContributorAuthor
cc. @zooba |
zooba
approved these changes
May 2, 2021
zooba
left a comment
Member
There was a problem hiding this comment.
Does not require backporting, as the backport of the original issue has the changes already applied.
Whoever merges should make the commit message a little more detailed.
erlend-aasland
commented
May 2, 2021
ContributorAuthor
zooba
commented
May 2, 2021
Member
I think having a reference to the function that was changed will be more helpful for searching later. |
erlend-aasland
commented
May 2, 2021
ContributorAuthor
Good point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43434