Skip to content

bpo-43795: Reword paragraph on specific value for Py_LIMITED_API - #26101

Merged
willingc merged 1 commit into
python:mainfrom
encukou:pep652-document
May 14, 2021
Merged

bpo-43795: Reword paragraph on specific value for Py_LIMITED_API#26101
willingc merged 1 commit into
python:mainfrom
encukou:pep652-document

Conversation

@encukou

@encukouencukou commented May 13, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

I spent some time on the wording here. Hopefully it is clearer when the 3 value is explained in terms of its longer equivalent.

https://bugs.python.org/issue43795

@bedevere-botbedevere-bot added the docs Documentation in the Doc dir label May 13, 2021
corona10
corona10 approved these changes May 13, 2021
View reviewed changes

@corona10corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

willingc
willingc approved these changes May 14, 2021
View reviewed changes

@willingcwillingc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @encukou.

@willingc
willingc merged commit ddd30b2 into python:mainMay 14, 2021
@encukou
encukou deleted the pep652-document branch May 14, 2021 07:52
@encukouencukou added the needs backport to 3.10 only security fixes label May 14, 2021
@miss-islington

miss-islington commented May 14, 2021

Copy link
Copy Markdown
Contributor

Thanks @encukou for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented May 14, 2021

Copy link
Copy Markdown

GH-26123 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label May 14, 2021
@encukou

encukou commented May 14, 2021

Copy link
Copy Markdown
MemberAuthor

Thank you for the reviews!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2021
@encukou@miss-islington
Reword paragraph on specific value for Py_LIMITED_API (pythonGH-26101)
e38992e
(cherry picked from commit ddd30b2)
Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou added a commit that referenced this pull request May 14, 2021
@miss-islington@encukou
Reword paragraph on specific value for Py_LIMITED_API (GH-26101) (GH-…
5abc681
…26123)
(cherry picked from commit ddd30b2)
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@pablogsalpablogsal mentioned this pull request Jul 18, 2021
Closed
@encukouencukou mentioned this pull request Jun 7, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingcwillingcwillingc approved these changes
@corona10corona10corona10 approved these changes
@erlend-aaslanderlend-aaslanderlend-aasland approved these changes
@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@encukou@miss-islington@bedevere-bot@willingc@corona10@erlend-aasland@Fidget-Spinner@the-knights-who-say-ni