bpo-29688: document and test `pathlib.Path.absolute()`. by barneygale · Pull Request #26153 · python/cpython

barneygale · 2021-05-15T22:09:48Z

This method is important and cannot be replaced with resolve()! resolve() will hit OS APIs to resolve symlinks/etc, and will fail on symlink loops, whereas absolute() just prepends the working directory and can never raise an OSError.

Also improved the table showing correspondence with os.path methods. The gory details:

Path.resolve() is os.path.realpath() in strict mode, with a tweaked exception type for symlink loops (backwards compat)
Path.absolute() is os.path.abspath() but without normalizing the path. The pathlib behaviour is better, as abspath()'s normlisation changes the meaning of the path in the presence of symlinks!

Happy to expand the tests if anyone has any ideas what else to cover.

https://bugs.python.org/issue29688

kalvdans · 2021-05-16T12:46:25Z

Documentation is clear and the suggested changes looks sane to me. Will take another look after windows test failures are addressed.

barneygale · 2021-05-16T21:44:23Z

Tested are fixed, thanks for taking a look.

kalvdans

Some small remarks.

barneygale · 2021-05-16T22:43:46Z

Note that this can't be automatically backported, as the tests' patching of getcwd() is different in 3.9 and below.

github-actions · 2021-07-15T00:04:44Z

This PR is stale because it has been open for 30 days with no activity.

brettcannon

One clarifying doc change as suggested by @domdfcoding. A news entry is also missing.

bedevere-bot · 2021-07-16T22:10:37Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

barneygale · 2022-01-01T01:12:47Z

Sorry for the long delay. Does this need a NEWS entry? It adds docs and tests but doesn't change the implementation of Path.absolute()

Co-authored-by: Brett Cannon <brett@python.org>

Co-authored-by: Brian Helba <brian.helba@kitware.com>

brettcannon · 2022-01-07T23:58:40Z

Sorry for the long delay. Does this need a NEWS entry? It adds docs and tests but doesn't change the implementation of Path.absolute()

It looks like you added a news entry anyway. 😄

brettcannon

Question about the docs and some very minor formatting things.

Co-authored-by: Brett Cannon <brett@python.org>

brettcannon · 2022-01-28T23:39:48Z

+ self.assertEqual(str(P('c:\\').absolute()), 'c:\\')
+ self.assertEqual(str(P('c:\\a').absolute()), 'c:\\a')
+ self.assertEqual(str(P('c:\\a\\b').absolute()), 'c:\\a\\b')
+
+ # UNC absolute paths.
+ share = '\\\\server\\share\\'
+ self.assertEqual(str(P(share).absolute()), share)
+ self.assertEqual(str(P(share + 'a').absolute()), share + 'a')
+ self.assertEqual(str(P(share + 'a\\b').absolute()), share + 'a\\b')


Suggested change
self.assertEqual(str(P('c:\\').absolute()), 'c:\\')
self.assertEqual(str(P('c:\\a').absolute()), 'c:\\a')
self.assertEqual(str(P('c:\\a\\b').absolute()), 'c:\\a\\b')
# UNC absolute paths.
share='\\\\server\\share\\'
self.assertEqual(str(P(share).absolute()), share)
self.assertEqual(str(P(share+'a').absolute()), share+'a')
self.assertEqual(str(P(share+'a\\b').absolute()), share+'a\\b')
self.assertEqual(str(P(r'c:\').absolute()), r'c:\')
self.assertEqual(str(P(r'c:\a').absolute()), r'c:\a')
self.assertEqual(str(P(r'c:\a\b').absolute()), r'c:\a\b')
# UNC absolute paths.
share='\\\\server\\share\\'
self.assertEqual(str(P(share).absolute()), share)
self.assertEqual(str(P(share+'a').absolute()), share+'a')
self.assertEqual(str(P(share+r'a\b').absolute()), share+r'a\b')

brettcannon · 2022-01-28T23:41:11Z

Thanks, @barneygale !

barneygale · 2022-01-29T00:16:41Z

Thanks very much for the review!

bedevere-bot added the awaiting review label May 15, 2021

the-knights-who-say-ni added the CLA signed label May 15, 2021

kalvdans approved these changes May 16, 2021
View reviewed changes

Comment threadLib/test/test_pathlib.py Outdated
Comment threadLib/test/test_pathlib.py Outdated
Comment threadLib/test/test_pathlib.py Outdated

bedevere-bot added awaiting core review and removed awaiting review labels May 16, 2021

barneygale mentioned this pull request May 16, 2021
bpo-43012: remove pathlib._Accessor#25701
Merged

kalvdans approved these changes May 17, 2021
View reviewed changes

eamanu reviewed May 18, 2021
View reviewed changes

Comment threadDoc/library/pathlib.rst Outdated

brettcannon self-requested a review June 14, 2021 19:15

ngnpope mentioned this pull request Jun 22, 2021
Replaced os module with pathlib for paths django/django#14553
Closed

github-actionsBot added the stale Stale PR or inactive for long period of time. label Jul 15, 2021

domdfcoding reviewed Jul 15, 2021
View reviewed changes

Comment threadDoc/library/pathlib.rst Outdated

brettcannon requested changes Jul 16, 2021
View reviewed changes

Comment threadDoc/library/pathlib.rst Outdated

bedevere-bot removed the awaiting core review label Jul 16, 2021

bedevere-bot added the awaiting changes label Jul 16, 2021

github-actionsBot removed the stale Stale PR or inactive for long period of time. label Jul 17, 2021

alneberg mentioned this pull request Oct 18, 2021
Abspath instead of resolve ScilifelabDataCentre/dds_cli#175
Merged

brianhelba reviewed Oct 25, 2021
View reviewed changes

Comment threadDoc/library/pathlib.rst Outdated

barneygaleand others added 6 commits January 1, 2022 01:21

bpo-29688: document and test pathlib.Path.absolute().
06b0c74

Add tests for UNC paths.
b5ff1e6

Fix Windows tests (attempt 1)
8695087

assertEqualNormCase() --> assertEqual()
5539824

Update Doc/library/pathlib.rst
7cd4fff
Co-authored-by: Brett Cannon <brett@python.org>

Update Doc/library/pathlib.rst
64204fd
Co-authored-by: Brian Helba <brian.helba@kitware.com>

barneygale force-pushed the bpo-29688-pathlib-absolute-docs-tests branch from 644703a to 64204fdCompare January 1, 2022 01:21

barneygale requested a review from brettcannon January 1, 2022 03:06

Add news entry.
b2bf3da

brettcannon requested changes Jan 8, 2022
View reviewed changes

barneygaleand others added 2 commits January 8, 2022 20:37

Apply suggestions from code review
2a9ebd0
Co-authored-by: Brett Cannon <brett@python.org>

Remove example in docs showing that .. entries are retained.
51aa187

barneygale requested a review from brettcannon January 16, 2022 23:07

brettcannon added awaiting change review and removed awaiting changes labels Jan 17, 2022

brettcannon approved these changes Jan 28, 2022
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Jan 28, 2022

brettcannon merged commit 18cb2ef into python:mainJan 28, 2022

bedevere-bot removed the awaiting merge label Jan 28, 2022

cacharle mentioned this pull request May 9, 2022
Update mlflow.set_tracking_uri to support pathlib.Path (#5820) mlflow/mlflow#5824
Merged
29 tasks

AA-Turner mentioned this pull request Nov 12, 2022
pathlib.Path.absolute not marked as "new in version 3.11" #99387
Closed

This was referenced Jan 8, 2023
Document various options for getting the absolute path from pathlib.Path objects #83271
Closed
Add support for Path.absolute() #73874
Closed

smcgivern mentioned this pull request May 30, 2023
fix(config): handle mixed relative and absolute paths tconbeer/sqlfmt#427
Merged

coderabbitaiBot mentioned this pull request Jul 27, 2026
control: compose bounded File scan cycles stone16/context-engine#119
Merged

coderabbitaiBot mentioned this pull request Aug 5, 2026
refactor(ingestion): extract docket-gap path validation johnhughes3/LegalForecastBench#451
Merged

-self.assertEqual(str(P('c:\\').absolute()), 'c:\\')
-self.assertEqual(str(P('c:\\a').absolute()), 'c:\\a')
-self.assertEqual(str(P('c:\\a\\b').absolute()), 'c:\\a\\b')
-# UNC absolute paths.
-share='\\\\server\\share\\'
-self.assertEqual(str(P(share).absolute()), share)
-self.assertEqual(str(P(share+'a').absolute()), share+'a')
-self.assertEqual(str(P(share+'a\\b').absolute()), share+'a\\b')
+self.assertEqual(str(P(r'c:\').absolute()), r'c:\')
+self.assertEqual(str(P(r'c:\a').absolute()), r'c:\a')
+self.assertEqual(str(P(r'c:\a\b').absolute()), r'c:\a\b')
+# UNC absolute paths.
+share='\\\\server\\share\\'
+self.assertEqual(str(P(share).absolute()), share)
+self.assertEqual(str(P(share+'a').absolute()), share+'a')
+self.assertEqual(str(P(share+r'a\b').absolute()), share+r'a\b')

Uh oh!

Uh oh!

Conversation

barneygale commented May 15, 2021• edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kalvdans commented May 16, 2021

Uh oh!

barneygale commented May 16, 2021

Uh oh!

kalvdans left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

barneygale commented May 16, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Jul 15, 2021

Uh oh!

Uh oh!

brettcannon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Jul 16, 2021

Uh oh!

Uh oh!

barneygale commented Jan 1, 2022

Uh oh!

brettcannon commented Jan 7, 2022

Uh oh!

brettcannon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brettcannonJan 28, 2022

Choose a reason for hiding this comment

Uh oh!

brettcannon commented Jan 28, 2022

Uh oh!

barneygale commented Jan 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

barneygale commented May 15, 2021•
edited by bedevere-bot
Loading

barneygale commented May 16, 2021•
edited
Loading

brettcannon left a comment •
edited
Loading