Skip to content

bpo-42972: Fully support GC for hashlib heap types (GH-26374) - #26374

Merged
tiran merged 4 commits into
python:mainfrom
erlend-aasland:bpo-42972/sha256
May 27, 2021
Merged

bpo-42972: Fully support GC for hashlib heap types (GH-26374)#26374
tiran merged 4 commits into
python:mainfrom
erlend-aasland:bpo-42972/sha256

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented May 25, 2021•
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

@tiran
tiran requested a review from gpsheadMay 26, 2021 14:55
@tirantiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
@bedevere-bot

bedevere-bot commented May 26, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 49226dd 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
@tiran

tiran commented May 26, 2021

Copy link
Copy Markdown
Member

@pablogsal@erlend-aasland Lots of buildbots have failed with Master Shutdown. Is this an infrastructure issues? Can I just restart the buildbots by setting the label again?

@erlend-aasland

erlend-aasland commented May 26, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@pablogsal@erlend-aasland Lots of buildbots have failed with Master Shutdown. Is this an infrastructure issues? Can I just restart the buildbots by setting the label again?

I've never seen this, but it does look like an infrastructure issue; the builds/tests did not fail, they were cancelled.

@pablogsal

pablogsal commented May 26, 2021

Copy link
Copy Markdown
Member

@pablogsal@erlend-aasland Lots of buildbots have failed with Master Shutdown. Is this an infrastructure issues? Can I just restart the buildbots by setting the label again?

That happens when the server restarts with an update, which happened because @vstinner updated the IRC configuration

@tirantiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
@bedevere-bot

bedevere-bot commented May 26, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 49226dd 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
@tirantiran changed the title bpo-42972: Fully support GC for hashlib heap typesbpo-42972: Fully support GC for hashlib heap types (GH-26374)May 27, 2021
@tiran
tiran merged commit 6ef5ba3 into python:mainMay 27, 2021
@miss-islington

miss-islington commented May 27, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @tiran for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented May 27, 2021

Copy link
Copy Markdown

GH-26398 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label May 27, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2021
Erlend Egeberg Aasland@miss-islington
bpo-42972: Fully support GC for hashlib heap types (pythonGH-26374)
0f2ec18
(cherry picked from commit 6ef5ba3)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aasland
erlend-aasland deleted the bpo-42972/sha256 branch May 27, 2021 07:52
@erlend-aasland

erlend-aasland commented May 27, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks for reviewing, @gpshead and @tiran! 🙏🏻

miss-islington added a commit that referenced this pull request May 27, 2021
@miss-islington
[3.10]bpo-42972: Fully support GC for hashlib heap types (GH-26374) (G…
4431922
…H-26398)
(cherry picked from commit 6ef5ba3)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Automerge-Triggered-By: GH:tiran
@pablogsalpablogsal mentioned this pull request Jul 18, 2021
Closed
@vstinnervstinner mentioned this pull request Jun 9, 2022
Closed
This was referenced Dec 6, 2024
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpsheadgpsheadgpshead approved these changes
@tirantirantiran approved these changes

Assignees

@gpsheadgpshead

@tirantiran

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@erlend-aasland@bedevere-bot@tiran@pablogsal@miss-islington@gpshead@the-knights-who-say-ni