Skip to content

bpo-44235: Remove deprecated functions in the gettext module. - #26378

Merged
corona10 merged 4 commits into
python:mainfrom
corona10:bpo-44235
May 30, 2021
Merged

bpo-44235: Remove deprecated functions in the gettext module.#26378
corona10 merged 4 commits into
python:mainfrom
corona10:bpo-44235

Conversation

@corona10

@corona10corona10 commented May 26, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@corona10corona10 changed the title bpo-44235: Remove deprecated functions in the gettext module.[WIP] bpo-44235: Remove deprecated functions in the gettext module.May 26, 2021
@corona10corona10 changed the title [WIP] bpo-44235: Remove deprecated functions in the gettext module.bpo-44235: Remove deprecated functions in the gettext module.May 26, 2021
serhiy-storchaka
serhiy-storchaka requested changes May 26, 2021
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused global variables and attributes.

Comment threadDoc/library/gettext.rst
Comment threadDoc/library/gettext.rst
Comment threadLib/gettext.py Outdated
Comment threadLib/gettext.py Outdated
Comment threadLib/gettext.py
Comment threadLib/gettext.py
Comment threadLib/test/test_gettext.py
@bedevere-bot

bedevere-bot commented May 26, 2021

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@corona10
corona10force-pushed the bpo-44235 branch 2 times, most recently from d38f80c to a5f6758CompareMay 27, 2021 14:45
@corona10

corona10 commented May 27, 2021

Copy link
Copy Markdown
MemberAuthor

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented May 27, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

serhiy-storchaka
serhiy-storchaka reviewed May 29, 2021
View reviewed changes
Comment threadLib/gettext.py Outdated
@corona10
corona10 merged commit 14ba761 into python:mainMay 30, 2021
@corona10
corona10 deleted the bpo-44235 branch May 30, 2021 01:29
This was referenced Apr 29, 2022
Closed
Closed
@donbarbosdonbarbos mentioned this pull request Aug 10, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10@bedevere-bot@serhiy-storchaka@the-knights-who-say-ni