Skip to content

bpo-43988: Use check disallow instantiation helper - #26392

Merged
vstinner merged 6 commits into
python:mainfrom
erlend-aasland:use-check-disallow-inst
May 27, 2021
Merged

bpo-43988: Use check disallow instantiation helper#26392
vstinner merged 6 commits into
python:mainfrom
erlend-aasland:use-check-disallow-inst

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented May 26, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor
  • Use test.support.check_disallow_instantiation
  • Fix exception message regex for builtins

https://bugs.python.org/issue43988

@erlend-aaslanderlend-aasland changed the title bpo-43988: Use check disallow instantiationbpo-43988: Use check disallow instantiation helperMay 26, 2021
vstinner
vstinner reviewed May 26, 2021
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to avoid tp = ... and then use tp, since "tp" name doesn't help: use directly "...". I wrote some examples.

Comment threadLib/test/support/__init__.py Outdated
Comment threadLib/test/test_curses.py Outdated
Comment threadLib/test/test_dbm_gnu.py Outdated
Comment threadLib/test/test_re.py Outdated
Comment threadLib/test/test_select.py Outdated
@vstinner
vstinner merged commit fbff538 into python:mainMay 27, 2021
@vstinner

vstinner commented May 27, 2021

Copy link
Copy Markdown
Member

Merged, thanks. This helper makes me more confident that the test actually checks that the type is immutable.

@erlend-aasland
erlend-aasland deleted the use-check-disallow-inst branch May 27, 2021 06:44
@erlend-aasland

erlend-aasland commented May 27, 2021

Copy link
Copy Markdown
ContributorAuthor

Merged, thanks. This helper makes me more confident that the test actually checks that the type is immutable.

Great, thanks for reviewing and improving the PR!

@erlend-aaslanderlend-aasland mentioned this pull request May 27, 2021
Merged
@erlend-aaslanderlend-aasland mentioned this pull request Jun 23, 2021
Merged
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jun 23, 2021
Erlend Egeberg Aasland
bpo-43988: Use check disallow instantiation helper (pythonGH-26392)
086565a
@erlend-aaslanderlend-aasland mentioned this pull request Jun 23, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments
@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger is a code owner
@tirantiranAwaiting requested review from tiran

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@vstinner@the-knights-who-say-ni@bedevere-bot