Skip to content

bpo-43693: Add the MAKE_CELL opcode and interleave fast locals offsets. - #26396

Merged
ericsnowcurrently merged 14 commits into
python:mainfrom
ericsnowcurrently:add-make-cell
Jun 7, 2021
Merged

bpo-43693: Add the MAKE_CELL opcode and interleave fast locals offsets.#26396
ericsnowcurrently merged 14 commits into
python:mainfrom
ericsnowcurrently:add-make-cell

Conversation

@ericsnowcurrently

@ericsnowcurrentlyericsnowcurrently commented May 27, 2021•
edited
Loading

Copy link
Copy Markdown
Member

This moves logic out of the frame initialization code and into the compiler and eval loop. Doing so simplifies the runtime code and allows us to optimize it better.

https://bugs.python.org/issue43693

@ericsnowcurrently
ericsnowcurrently removed the request for review from tiranMay 27, 2021 02:34
@ericsnowcurrentlyericsnowcurrently mentioned this pull request May 27, 2021
Closed
markshannon
markshannon reviewed May 27, 2021
View reviewed changes
Comment threadInclude/cpython/code.h Outdated
@ericsnowcurrentlyericsnowcurrently mentioned this pull request May 27, 2021
Merged
markshannon
markshannon reviewed Jun 4, 2021
View reviewed changes

@markshannonmarkshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a couple of Windows warnings.

Comment threadDoc/library/dis.rst Outdated
Comment threadInclude/cpython/code.h Outdated
Comment threadInclude/cpython/code.h Outdated
Comment threadLib/opcode.py Outdated

@markshannonmarkshannonJun 4, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the opcode shuffle?

@ericsnowcurrentlyericsnowcurrentlyJun 4, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My initial impression was that MAKE_CELL should be at the front of the cell-related list and I figured it would be better to preserve the gap at 134. I figured it wouldn't matter but if it's a problem I can put MAKE_CELL at 139.

Comment threadMisc/NEWS.d/next/Core and Builtins/2021-05-26-19-10-47.bpo-43693.1KSG9u.rst Outdated
Comment threadObjects/frameobject.c Outdated
Comment threadObjects/frameobject.c Outdated
Comment threadPython/ceval.c Outdated
Comment threadPython/ceval.c Outdated
@ericsnowcurrentlyericsnowcurrently mentioned this pull request Jun 4, 2021
Closed
@ericsnowcurrentlyericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 7, 2021
@bedevere-bot

bedevere-bot commented Jun 7, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 05accc0 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 7, 2021
@ericsnowcurrently
ericsnowcurrently merged commit 631f993 into python:mainJun 7, 2021
@ericsnowcurrently
ericsnowcurrently deleted the add-make-cell branch June 7, 2021 22:52
pablogsal added a commit to pablogsal/cpython that referenced this pull request Jun 8, 2021
@pablogsal
Revert "bpo-43693: Add the MAKE_CELL opcode and interleave fast local…
01ff3e0
…s offsets. (pythongh-26396)"
This reverts commit 631f993.
pablogsal added a commit that referenced this pull request Jun 8, 2021
@pablogsal
Revert "bpo-43693: Add the MAKE_CELL opcode and interleave fast local…
3fe921c
…s offsets. (gh-26396)" (GH-26597)
This reverts commit 631f993.
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Jun 8, 2021
@ericsnowcurrently
Un-revert "bpo-43693: Add the MAKE_CELL opcode and interleave fast lo…
ddcfb69
…cals offsets. (pythongh-26396)"
That commit (3fe921c) was reverted in pythonGH-26597
(3fe921c).
@ericsnowcurrentlyericsnowcurrently mentioned this pull request Jun 8, 2021
Merged
ericsnowcurrently added a commit that referenced this pull request Jun 8, 2021
@ericsnowcurrently
bpo-43693: Un-revert commit f3fa63e. (#26609)
3e1c716
This was reverted in GH-26596 (commit 6d518bb) due to some bad memory accesses.
* Add the MAKE_CELL opcode. (gh-26396)
The memory accesses have been fixed.
https://bugs.python.org/issue43693
@markshannonmarkshannon mentioned this pull request May 2, 2022
Closed
@ericsnowcurrentlyericsnowcurrently mentioned this pull request Sep 8, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannonmarkshannonmarkshannon left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ericsnowcurrently@bedevere-bot@markshannon@the-knights-who-say-ni