bpo-43858: Add logging.getLevelNamesMapping() by akulakov · Pull Request #26459 · python/cpython

akulakov · 2021-05-31T04:46:40Z

Added a function that returns a copy of a dict of logging levels.

https://bugs.python.org/issue43858

ericvsmith

This needs tests. In particular it should add tests that a copy is returned.

bedevere-bot · 2021-05-31T06:38:57Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

akulakov · 2021-05-31T15:04:24Z

I have made the requested changes; please review again

bedevere-bot · 2021-05-31T15:04:27Z

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

ericvsmith

This is looking good to me. @vsajip : I'll let you have the final word.

bedevere-bot · 2021-05-31T15:48:52Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ericvsmith · 2021-06-01T01:10:40Z

@@ -0,0 +1 @@
+Added a function that returns a copy of a dict of logging levels: func::`logging.getLevelNamesMapping()`


Now that I look at this: isn't the correct syntax:
:func:`logging.getLevelNamesMapping`
?

You are right, well spotted!

akulakov · 2021-06-01T01:46:40Z

@vsajip @ericvsmith Pushed an update per comments, please take a look!

ericvsmith

With the one small item I mentioned, this looks good to me.

ericvsmith · 2021-06-01T16:39:51Z

@@ -0,0 +1 @@
+Added a function that returns a copy of a dict of logging levels: :func:`logging.getLevelNamesMapping()`


My understanding is that :func: adds the parens, so you should leave them off in this message. I've looked at other files, and they don't have the parens.

akulakov · 2021-06-01T17:02:12Z

@ericvsmith I fixed the parens, please take a look..

vsajip

Accidental double-definition in test?

vsajip · 2021-06-02T14:41:43Z

 self.assertEqual(rc, 1)

+ def test_get_level_names_mapping(self):
+ def test_get_level_names_mapping(self):


I don't think you meant this double level of indentation! That causes the test to do nothing effective 😞

Whoops, somehow doubling made it hard to spot for me..

akulakov · 2021-06-02T15:13:07Z

@vsajip Fixed the doubled test..

ericvsmith

This all looks good to me. Thanks, @akulakov !

akulakov · 2021-06-05T16:46:06Z

@ericvsmith and @vsajip much thanks for the help with the PR!

akulakov added 2 commits May 31, 2021 00:28

added getLevelNamesDict()
f80b73a

Added getLevelNamesDict doc
e5601b0

akulakov requested a review from vsajip as a code owner May 31, 2021 04:46

bedevere-bot added the awaiting review label May 31, 2021

the-knights-who-say-ni added the CLA signed label May 31, 2021

blurb-itBotand others added 2 commits May 31, 2021 04:51

📜🤖 Added by blurb_it.
72a6efa

Add getLevelNamesDict() to __all__
e59141b

ericvsmith requested changes May 31, 2021
View reviewed changes

Comment threadDoc/library/logging.rst Outdated
Comment threadLib/logging/__init__.py Outdated

bedevere-bot removed the awaiting review label May 31, 2021

bedevere-bot added the awaiting changes label May 31, 2021

akulakov added 4 commits May 31, 2021 10:53

Updated func name; expanded doc; added unit test
bebd56a

fix indentation on __all__
0fffa1c

fix __all__ again
f56e012

updated new entry
f578c79

bedevere-bot added awaiting change review and removed awaiting changes labels May 31, 2021

bedevere-bot requested a review from ericvsmith May 31, 2021 15:04

ericvsmith requested changes May 31, 2021
View reviewed changes

Comment threadDoc/library/logging.rst Outdated
Comment threadLib/test/test_logging.py Outdated
Comment threadDoc/library/logging.rst Outdated

bedevere-bot added awaiting changes and removed awaiting change review labels May 31, 2021

vsajip requested changes May 31, 2021
View reviewed changes

Comment threadLib/test/test_logging.py Outdated

vsajip added the 🤖 automerge label May 31, 2021

ericvsmith reviewed Jun 1, 2021
View reviewed changes

fixed typo in news; expanded tests; added example to the doc
cc7a8c8

fix2 for news
e71183e

ericvsmith reviewed Jun 1, 2021
View reviewed changes

remove parens from doc link
3d41503

vsajip requested changes Jun 2, 2021
View reviewed changes

fixed double definition of test
5b1631c

ericvsmith reviewed Jun 2, 2021
View reviewed changes

akulakov changed the title ~~bpo-43858: Add logging.getLevelNamesDict()~~bpo-43858: Add logging.getLevelNamesMapping()Jun 2, 2021

vsajip approved these changes Jun 3, 2021
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels Jun 3, 2021

miss-islington merged commit 8b93f0e into python:mainJun 3, 2021

bedevere-bot removed the awaiting merge label Jun 3, 2021

CAM-Gerlach mentioned this pull request Oct 16, 2022
gh-95913: Add WhatsNew section for new logging APIs #98320
Merged

		@@ -0,0 +1 @@
		Added a function that returns a copy of a dict of logging levels: func::`logging.getLevelNamesMapping()`

Uh oh!

Uh oh!

Conversation

akulakov commented May 31, 2021• edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericvsmith left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented May 31, 2021

Uh oh!

akulakov commented May 31, 2021

Uh oh!

bedevere-bot commented May 31, 2021

Uh oh!

ericvsmith left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented May 31, 2021

Uh oh!

Uh oh!

ericvsmithJun 1, 2021

Choose a reason for hiding this comment

Uh oh!

akulakovJun 1, 2021

Choose a reason for hiding this comment

Uh oh!

akulakov commented Jun 1, 2021

Uh oh!

ericvsmith left a comment

Choose a reason for hiding this comment

Uh oh!

ericvsmithJun 1, 2021

Choose a reason for hiding this comment

Uh oh!

akulakov commented Jun 1, 2021

Uh oh!

vsajip left a comment

Choose a reason for hiding this comment

Uh oh!

vsajipJun 2, 2021

Choose a reason for hiding this comment

Uh oh!

akulakovJun 2, 2021

Choose a reason for hiding this comment

Uh oh!

akulakov commented Jun 2, 2021

Uh oh!

ericvsmith left a comment

Choose a reason for hiding this comment

Uh oh!

akulakov commented Jun 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

akulakov commented May 31, 2021•
edited by bedevere-bot
Loading