Skip to content

bpo-44291: Fix reconnection in logging.handlers.SysLogHandler (GH-26490) - #26490

Merged
vsajip merged 1 commit into
python:mainfrom
cybergrind:fix-issue-44291
Aug 5, 2021
Merged

bpo-44291: Fix reconnection in logging.handlers.SysLogHandler (GH-26490)#26490
vsajip merged 1 commit into
python:mainfrom
cybergrind:fix-issue-44291

Conversation

@cybergrind

@cybergrindcybergrind commented Jun 2, 2021

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue44291

./python -m test test_logging -m SysLogHandlerTest

@cybergrind
cybergrind requested a review from vsajip as a code ownerJune 2, 2021 19:06
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@cybergrind

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@cybergrind

Copy link
Copy Markdown
ContributorAuthor

Hi, @vsajip Not sure where is better to remind about PR. It would be great if you could look into it

@vsajip

Copy link
Copy Markdown
Member

Hi Kirill, sorry I haven't been able to get to it thus far. I hope to be able to review this soon - say by the middle of next week; this week I am very busy on other stuff that is more urgent. Thanks for your patience.

@vsajip

Copy link
Copy Markdown
Member

Closing and reopening to re-run stalled checks.

@vsajipvsajip closed this Aug 5, 2021
@vsajipvsajip reopened this Aug 5, 2021
@vsajipvsajip changed the title bpo-44291: Fix reconnection in logging.handlers.SysLogHandlerbpo-44291: Fix reconnection in logging.handlers.SysLogHandler (GH-26490)Aug 5, 2021
@vsajip
vsajip merged commit 3d315c3 into python:mainAug 5, 2021
@sahilsangani98

sahilsangani98 commented Nov 29, 2022

Copy link
Copy Markdown

Is this issue resolved with Python version 3.9 as well?

If no, how to resolve this error with Python version 3.9 as I can't upgrade my services with Python 3.11.

It will be really appreciated if someone can guide me on this.

@cybergrind
@vsajip
@alex

@vsajip

Copy link
Copy Markdown
Member

Simplest: Why not copy the handler from 3.11 to your own code and use that?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@cybergrind@the-knights-who-say-ni@vsajip@sahilsangani98@bedevere-bot