Skip to content

[3.8] bpo-44022: Improve the regression test. (GH-26503) - #26506

Merged
ambv merged 1 commit into
python:3.8from
miss-islington:backport-e60ab84-3.8
Jul 12, 2021
Merged

[3.8] bpo-44022: Improve the regression test. (GH-26503)#26506
ambv merged 1 commit into
python:3.8from
miss-islington:backport-e60ab84-3.8

Conversation

@miss-islington

@miss-islingtonmiss-islington commented Jun 3, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

It wasn't actually detecting the regression due to the
assertion being too lenient.
(cherry picked from commit e60ab84)

Co-authored-by: Gregory P. Smith greg@krypto.org

https://bugs.python.org/issue44022

Automerge-Triggered-By: GH:gpshead

@gpshead@miss-islington
bpo-44022: Improve the regression test. (pythonGH-26503)
730fc95
It wasn't actually detecting the regression due to the
assertion being too lenient.
(cherry picked from commit e60ab84)
Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-botbedevere-bot mentioned this pull request Jun 3, 2021
Merged
@bedevere-botbedevere-bot added skip news type-security A security issue tests Tests in the Lib/test dir awaiting review labels Jun 3, 2021
@miss-islington

miss-islington commented Jun 3, 2021

Copy link
Copy Markdown
ContributorAuthor

@gpshead: Status check is done, and it's a success ✅ .

@miss-islington

miss-islington commented Jun 3, 2021

Copy link
Copy Markdown
ContributorAuthor

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@github-actions

github-actionsBot commented Jul 4, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Jul 4, 2021
@miss-islington

miss-islington commented Jul 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@github-actionsgithub-actionsBot removed the stale Stale PR or inactive for long period of time. label Jul 5, 2021
@ambv
ambv merged commit 0389426 into python:3.8Jul 12, 2021
@bedevere-bot

bedevere-bot commented Jul 12, 2021

Copy link
Copy Markdown

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
miss-islington deleted the backport-e60ab84-3.8 branch July 12, 2021 15:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpsheadgpsheadgpshead approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dirtype-securityA security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington@bedevere-bot@gpshead@ambv@the-knights-who-say-ni