Skip to content

bpo-44315: Remove unused connection argument from pysqlite_step() - #26535

Merged
pablogsal merged 1 commit into
python:mainfrom
erlend-aasland:sqlite-remove-unused-step-argument
Jun 4, 2021
Merged

bpo-44315: Remove unused connection argument from pysqlite_step()#26535
pablogsal merged 1 commit into
python:mainfrom
erlend-aasland:sqlite-remove-unused-step-argument

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland

Copy link
Copy Markdown
ContributorAuthor

This is an internal change; no news required.

@pablogsal

Copy link
Copy Markdown
Member

Why we weren't getting compiler warnings for this?

@erlend-aasland

Copy link
Copy Markdown
ContributorAuthor

Why we weren't getting compiler warnings for this?

Good question. The thought has crossed my mind too. There are definitely other compiler warnings in sqlite3 (for example unused function return values).

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@pablogsal@the-knights-who-say-ni@bedevere-bot