Skip to content

bpo-44313: generate LOAD_ATTR/CALL_FUNCTION for top-level imported objects - #26677

Merged
markshannon merged 2 commits into
python:mainfrom
isidentical:bpo-44313
Jun 30, 2021
Merged

bpo-44313: generate LOAD_ATTR/CALL_FUNCTION for top-level imported objects#26677
markshannon merged 2 commits into
python:mainfrom
isidentical:bpo-44313

Conversation

@isidentical

@isidenticalisidentical commented Jun 11, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@isidenticalisidentical changed the title bpo-44313: generate LOAD_ATTR/CALL_FUNCTION for top-level imported ob…bpo-44313: generate LOAD_ATTR/CALL_FUNCTION for top-level imported objectsJun 11, 2021
@isidentical
isidenticalforce-pushed the bpo-44313 branch 4 times, most recently from 86f2a4d to c7c708cCompareJune 11, 2021 18:22
markshannon
markshannon requested changes Jun 14, 2021
View reviewed changes

@markshannonmarkshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Just two very minor issues.

Comment threadMisc/NEWS.d/next/Core and Builtins/2021-06-10-16-10-39.bpo-44313.34RjI8.rst Outdated
Comment threadLib/test/test_compile.py Outdated
@bedevere-bot

bedevere-bot commented Jun 14, 2021

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@isidentical

isidentical commented Jun 18, 2021

Copy link
Copy Markdown
MemberAuthor

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jun 18, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

@Fidget-SpinnerFidget-Spinner mentioned this pull request Jun 29, 2021
Merged
markshannon
markshannon approved these changes Jun 29, 2021
View reviewed changes

@markshannonmarkshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.
Sorry I missed your update, so importlib needs updating again.

@isidentical

isidentical commented Jun 29, 2021

Copy link
Copy Markdown
MemberAuthor

Okay will regenerate them tomorrow.

@isidenticalisidentical added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 30, 2021
@bedevere-bot

bedevere-bot commented Jun 30, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @isidentical for commit ab1b6c1 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 30, 2021
@markshannon

markshannon commented Jun 30, 2021

Copy link
Copy Markdown
Member

Thanks.

@markshannon
markshannon merged commit 1b28187 into python:mainJun 30, 2021
sweeneyde
sweeneyde reviewed Jul 1, 2021
View reviewed changes
Comment threadLib/importlib/_bootstrap_external.py
# Python 3.11a1 3455 (add MAKE_CELL bpo-43693)
# Python 3.11a1 3456 (interleave cell args bpo-43693)
# Python 3.11a1 3457 (Change localsplus to a bytes object bpo-43693)
# Python 3.11a1 3458 (imported objects now don't use LOAD_METHOD/CALL_METHOD)

@sweeneydesweeneydeJul 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the actual number be bumped below? I don't think it matters much in this case, but for the sake of consistency/clarity for the next bump, it might be good to fix.

@isidenticalisidenticalJul 1, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, probably got away during rebase. Will fix

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sweeneydesweeneydesweeneyde left review comments
@markshannonmarkshannonmarkshannon approved these changes
@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@isidentical@bedevere-bot@markshannon@Fidget-Spinner@sweeneyde@the-knights-who-say-ni