Skip to content

bpo-44229: Intest_ssl, ignore spurious EPROTOTYPE on macOS - #26893

Merged
pablogsal merged 1 commit into
python:mainfrom
erlend-aasland:bpo-44229
Jun 24, 2021
Merged

bpo-44229: Intest_ssl, ignore spurious EPROTOTYPE on macOS#26893
pablogsal merged 1 commit into
python:mainfrom
erlend-aasland:bpo-44229

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jun 24, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-botbedevere-bot added awaiting review tests Tests in the Lib/test dir labels Jun 24, 2021
@erlend-aasland

erlend-aasland commented Jun 24, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Backport though to 3.9? (...maybe even 3.8, since it's breaking CI)

@pablogsal

pablogsal commented Jun 24, 2021

Copy link
Copy Markdown
Member

Backport though to 3.9? (...maybe even 3.8, since it's breaking CI)

Is the error happening on 3.9 and 3.8? I though this only happened in 3.10 and main

@pablogsal

pablogsal commented Jun 24, 2021

Copy link
Copy Markdown
Member

Ok, I saw https://bugs.python.org/msg396471 :)

@erlend-aasland

erlend-aasland commented Jun 24, 2021

Copy link
Copy Markdown
ContributorAuthor

I think we've just let it pass as a flakey ssl test earlier. With PEP 644, the ssl tests have been heavily scrutinised :)

@pablogsal

pablogsal commented Jun 24, 2021

Copy link
Copy Markdown
Member

Also, question, in your message there are 3 different exceptions:

ConnectionResetError: [Errno 54] Connection reset by peer

 OSError: [Errno 41] Protocol wrong type for socket

ConnectionRefusedError: [Errno 61] Connection refused

are all of this fixed by this PR?

@erlend-aasland

erlend-aasland commented Jun 24, 2021

Copy link
Copy Markdown
ContributorAuthor

Yes. Errno 41 always happens in the mock server set up by the test. On the client side, this results in either errno 54 or errno 61.

@pablogsal
pablogsal merged commit b5a52ee into python:mainJun 24, 2021
@miss-islington

miss-islington commented Jun 24, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Jun 24, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jun 24, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2021
Erlend Egeberg Aasland@miss-islington
bpo-44229: Ignore spurious EPROTOTYPE on macOS in test_ssl (pythonGH-…
12ecc07
…26893)
(cherry picked from commit b5a52ee)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot

bedevere-bot commented Jun 24, 2021

Copy link
Copy Markdown

GH-26894 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2021
Erlend Egeberg Aasland@miss-islington
bpo-44229: Ignore spurious EPROTOTYPE on macOS in test_ssl (pythonGH-…
5d0c1f2
…26893)
(cherry picked from commit b5a52ee)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot

bedevere-bot commented Jun 24, 2021

Copy link
Copy Markdown

GH-26895 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2021
Erlend Egeberg Aasland@miss-islington
bpo-44229: Ignore spurious EPROTOTYPE on macOS in test_ssl (pythonGH-…
d87a47c
…26893)
(cherry picked from commit b5a52ee)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot

bedevere-bot commented Jun 24, 2021

Copy link
Copy Markdown

GH-26896 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Jun 24, 2021
@erlend-aasland
erlend-aasland deleted the bpo-44229 branch June 24, 2021 12:13
miss-islington added a commit that referenced this pull request Jun 24, 2021
@miss-islingtonErlend Egeberg Aasland
bpo-44229: Ignore spurious EPROTOTYPE on macOS in test_ssl (GH-26893)
0796e21
(cherry picked from commit b5a52ee)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington added a commit that referenced this pull request Jun 24, 2021
@miss-islingtonErlend Egeberg Aasland
bpo-44229: Ignore spurious EPROTOTYPE on macOS in test_ssl (GH-26893)
b3fac29
(cherry picked from commit b5a52ee)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
pablogsal pushed a commit that referenced this pull request Jun 24, 2021
@miss-islingtonErlend Egeberg Aasland
bpo-44229: Ignore spurious EPROTOTYPE on macOS in test_ssl (GH-26893) (…
71ba16b
…GH-26895)
(cherry picked from commit b5a52ee)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@pablogsalpablogsal mentioned this pull request Jul 18, 2021
Closed
This was referenced Aug 4, 2022
Closed
Closed
@erlend-aaslanderlend-aasland mentioned this pull request Apr 3, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes
@tirantiranAwaiting requested review from tiran
@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

awaiting mergeskip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland@pablogsal@miss-islington@bedevere-bot@the-knights-who-say-ni