Uh oh!
There was an error while loading. Please reload this page.
bpo-43950: Print columns in tracebacks (PEP 657) - #26958
Conversation
d69a6a4 to
6d4302dComparepablogsal
commented
Jul 2, 2021
@ammaraskar Ground control to major tom, commencing countdown engines on Rebase time! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
6d4302d to
1fd558cCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
pablogsal
commented
Jul 4, 2021
Yeah, I will do that. Could you address first @isidentical feedback? |
73bcea3 to
9a31711Comparee0b1f4b to
58e2f7fComparepablogsal
commented
Jul 5, 2021
@ammaraskar Can you open the prs for the follow-ups? |
ammaraskar
commented
Jul 5, 2021
#27023 for the config change, working on the traceback.py refactor + a bpo issue. |
ammaraskar
commented
Jul 5, 2021
https://bugs.python.org/issue44569 for the traceback.py change, PR for it coming soon. |
| """ | ||
| if f is None: | ||
| f = sys._getframe().f_back.f_back | ||
| f = sys._getframe().f_back.f_back.f_back.f_back |
There was a problem hiding this comment.
this doesn't seem correct -
Python 3.11.0 | packaged by conda-forge | (main, Oct 25 2022, 06:18:27) [GCC 10.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import traceback
>>> traceback.walk_stack(None)
<generator object walk_stack at 0x7f308f4c4700>
>>> list(traceback.walk_stack(None))
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/graingert/anaconda3/envs/dask-distributed-311/lib/python3.11/traceback.py", line 332, in walk_stack
f = sys._getframe().f_back.f_back.f_back.f_back
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'f_back'
>>> There was a problem hiding this comment.
Please, don't comment on merged pull requests because they are not monitored and you risk no one looking at your comment. Always open a new issue :)
This pull request implements the relevant bits in traceback printing to utilize the new
co_positionsandPyCode_Addr2...APIs to print carets for column locations.All the internal structures, and data representation are subjected to change in future PRs as we add optimizations.
https://bugs.python.org/issue43950