Skip to content

bpo-43950: make BinOp specializations more reliable - #27126

Merged
pablogsal merged 1 commit into
python:mainfrom
isidentical:bpo-43950-proper-specialization
Jul 15, 2021
Merged

bpo-43950: make BinOp specializations more reliable#27126
pablogsal merged 1 commit into
python:mainfrom
isidentical:bpo-43950-proper-specialization

Conversation

@isidentical

@isidenticalisidentical commented Jul 13, 2021

Copy link
Copy Markdown
Member

Ensure that we are parsing the correct segment ([right->end, left->start)) for BinOps.

https://bugs.python.org/issue43950

Comment threadLib/test/test_traceback.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind lining up the carets with the code just so these tests are easier to read.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed to your fork the fix

@pablogsal
pablogsalforce-pushed the bpo-43950-proper-specialization branch from 442a9e0 to 85eabf2CompareJuly 15, 2021 22:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@isidentical@ammaraskar@pablogsal@the-knights-who-say-ni@bedevere-bot