Skip to content

bpo-40897:Give priority to using the current class constructor in inspect.signature - #27177

Merged
ambv merged 2 commits into
python:mainfrom
hongweipeng:inspect-signature-use-current-class-first
Jul 16, 2021
Merged

bpo-40897:Give priority to using the current class constructor in inspect.signature#27177
ambv merged 2 commits into
python:mainfrom
hongweipeng:inspect-signature-use-current-class-first

Conversation

@hongweipeng

@hongweipenghongweipeng commented Jul 16, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@mauvilsa

mauvilsa commented Jul 16, 2021

Copy link
Copy Markdown
Contributor

@hongweipeng could you please comment here or in https://bugs.python.org/issue40897 if this fixes what I commented about the datetime classes. If it does fix it, would it be okay to add a unit test which checks getting the signature of e.g. datetime.timedelta?

@ambv

ambv commented Jul 16, 2021

Copy link
Copy Markdown
Contributor

@mauvilsa, as you rightfully noticed yourself, this is a separate issue. Thanks for creating BPO-44618, we will deal with this separately.

@ambv

ambv commented Jul 16, 2021

Copy link
Copy Markdown
Contributor

Address sanitizer failure unrelated.

@ambv
ambv merged commit 6aab5f9 into python:mainJul 16, 2021
@bedevere-bot

bedevere-bot commented Jul 16, 2021

Copy link
Copy Markdown

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

miss-islington commented Jul 16, 2021

Copy link
Copy Markdown
Contributor

Thanks @hongweipeng for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 16, 2021

Copy link
Copy Markdown
Contributor

Thanks @hongweipeng for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 16, 2021

Copy link
Copy Markdown
Contributor

Sorry, @hongweipeng and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6aab5f9bf303a8e4cd8377fabcdcb499e0541f9a 3.9

@miss-islington

miss-islington commented Jul 16, 2021

Copy link
Copy Markdown
Contributor

Sorry @hongweipeng and @ambv, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6aab5f9bf303a8e4cd8377fabcdcb499e0541f9a 3.10

@sthagensthagen mentioned this pull request Jul 16, 2021
Merged
@miss-islington

miss-islington commented Jul 16, 2021

Copy link
Copy Markdown
Contributor

Thanks @hongweipeng for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 16, 2021

Copy link
Copy Markdown
Contributor

Thanks @hongweipeng for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jul 16, 2021

Copy link
Copy Markdown

GH-27189 is a backport of this pull request to the 3.10 branch.

@miss-islington

miss-islington commented Jul 16, 2021

Copy link
Copy Markdown
Contributor

Sorry, @hongweipeng and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6aab5f9bf303a8e4cd8377fabcdcb499e0541f9a 3.9

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Jul 16, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2021
@hongweipeng@miss-islington
bpo-40897:Give priority to using the current class constructor in `in…
007cf76
…spect.signature` (pythonGH-27177)
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 6aab5f9)
Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
ambv pushed a commit that referenced this pull request Jul 16, 2021
@miss-islington@hongweipeng
bpo-40897:Give priority to using the current class constructor in `in…
948e39a
…spect.signature` (GH-27177) (#27189)
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 6aab5f9)
Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
@ambvambv mentioned this pull request Jul 16, 2021
Merged
@miss-islington

miss-islington commented Jul 17, 2021

Copy link
Copy Markdown
Contributor

Thanks @hongweipeng for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jul 17, 2021

Copy link
Copy Markdown

GH-27209 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2021
@hongweipeng@miss-islington
bpo-40897:Give priority to using the current class constructor in `in…
e1e5a3b
…spect.signature` (pythonGH-27177)
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 6aab5f9)
Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
ambv pushed a commit that referenced this pull request Jul 17, 2021
@miss-islington@hongweipeng
bpo-40897:Give priority to using the current class constructor in `in…
df7c629
…spect.signature` (GH-27177) (GH-27209)
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 6aab5f9)
Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
@pablogsalpablogsal mentioned this pull request Jul 18, 2021
Closed
@hongweipeng
hongweipeng deleted the inspect-signature-use-current-class-first branch December 5, 2021 14:48
@mauvilsamauvilsamannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ambvambv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hongweipeng@mauvilsa@ambv@bedevere-bot@miss-islington@the-knights-who-say-ni