Uh oh!
There was an error while loading. Please reload this page.
bpo-43950: support some multi-line expressions for PEP 657 - #27339
Conversation
ff6022e to
8d8136fCompare
pablogsal
left a comment
There was a problem hiding this comment.
I recall they we had this version implemented but we did abandoned it because it looked weird in done scenarios. I am missing anything or is the fact that we are stopping in whitespace enough to account for the problems with the old approach?
isidentical
commented
Jul 24, 2021
The old approach was highlighting the whole line if the |
pablogsal
commented
Jul 24, 2021
Can you add some extra tests with some specific cases like function calls spawning multiple lines as well as binops spawning multiple lines (for example)? I will like to cover this with more cases if possible, |
pablogsal
left a comment
There was a problem hiding this comment.
LGTM modulo my comment regarding more tests
miss-islington
commented
Jul 25, 2021
@isidentical: Status check is done, and it's a success ✅ . |
This is basically something that I noticed up while fixing test runs for another issue. It is really common to have multiline calls, and when they fail the display is kind of weird since we omit the annotations. E.g;
This patch basically adds support for annotating the rest of the line, if the instruction covers multiple lines (start_line != end_line).
https://bugs.python.org/issue43950
Automerge-Triggered-By: GH:isidentical