Skip to content

bpo-33671 fix orphaned comment in shutil.copyfileobj - #27516

Merged
merwok merged 1 commit into
python:mainfrom
asottile:patch-1
Jul 31, 2021
Merged

bpo-33671 fix orphaned comment in shutil.copyfileobj#27516
merwok merged 1 commit into
python:mainfrom
asottile:patch-1

Conversation

@asottile

@asottileasottile commented Jul 31, 2021

Copy link
Copy Markdown
Contributor

looks like this was accidentally orphaned in #12016

(requesting skip-news skip-issue)

https://bugs.python.org/issue33671

@merwokmerwok changed the title fix orphaned comment in shutil.copyfileobjbpo-33671 fix orphaned comment in shutil.copyfileobjJul 31, 2021
@merwok
merwok merged commit b08c48e into python:mainJul 31, 2021
@merwok

Copy link
Copy Markdown
Member

Thanks! Agreed that creating a full ticket for this would be overkill, but I added the original one to link the two changes together.

Does this need backports? Original PR went into 3.8.

@asottile
asottile deleted the patch-1 branch July 31, 2021 19:33
@asottile

Copy link
Copy Markdown
ContributorAuthor

could be backported, I don't think it's super critical to backport (but fairly safe!)

@merwok

Copy link
Copy Markdown
Member

Maybe it’s enough to have it on the main branch then. Thanks for the patch!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@asottile@merwok@the-knights-who-say-ni@bedevere-bot