Skip to content

bpo-43853: Expand test suite for SQLite UDF's - #27642

Merged
gvanrossum merged 16 commits into
python:mainfrom
erlend-aasland:sqlite-test-udf-str-with-null
Jan 26, 2022
Merged

bpo-43853: Expand test suite for SQLite UDF's#27642
gvanrossum merged 16 commits into
python:mainfrom
erlend-aasland:sqlite-test-udf-str-with-null

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Aug 6, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Test that strings that contain embedded NULL characters are passed to UDF's
  • Consolidate "test param" tests to reduce the amount of boilerplate code
  • Test more error conditions when building UDF arguments, and returning UDF values
  • Handle PyFloat_AsDouble() errors

https://bugs.python.org/issue43853

@erlend-aasland

erlend-aasland commented Aug 6, 2021

Copy link
Copy Markdown
ContributorAuthor

FYI: Tests for aggregate functions are already in place (implemented in GH-27588).

@serhiy-storchaka, is the refactor commit acceptable? Code coverage is preserved.

serhiy-storchaka
serhiy-storchaka reviewed Aug 6, 2021
View reviewed changes
Comment threadLib/sqlite3/test/userfunctions.py
Comment threadLib/sqlite3/test/userfunctions.py
Comment threadLib/sqlite3/test/userfunctions.py
Comment threadLib/sqlite3/test/userfunctions.py Outdated
@serhiy-storchaka

serhiy-storchaka commented Aug 7, 2021

Copy link
Copy Markdown
Member

Ignore my comments about values which cause errors. I covered them in #27654. But please add more test cases for valid values of different types.

This was referenced Aug 7, 2021
Merged
Merged
serhiy-storchaka
serhiy-storchaka reviewed Aug 8, 2021
View reviewed changes
Comment threadModules/_sqlite/connection.c
Comment threadLib/sqlite3/test/userfunctions.py
Comment threadLib/sqlite3/test/userfunctions.py Outdated
Comment threadLib/sqlite3/test/userfunctions.py Outdated
Comment threadLib/sqlite3/test/userfunctions.py Outdated
Comment threadLib/sqlite3/test/userfunctions.py
@erlend-aasland

erlend-aasland commented Aug 12, 2021

Copy link
Copy Markdown
ContributorAuthor

I've updated the PR. PTAL, @serhiy-storchaka.

@erlend-aasland
erlend-aasland marked this pull request as draft September 14, 2021 21:44
@erlend-aasland

erlend-aasland commented Sep 14, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Marked as draft, as I need to resolve some potential issues created by GH-27884.

Resolved: only test arguments passed to UDF's

@erlend-aasland
erlend-aasland marked this pull request as ready for review September 15, 2021 08:23
@erlend-aasland

erlend-aasland commented Sep 15, 2021

Copy link
Copy Markdown
ContributorAuthor

@serhiy-storchaka, please take a new look.

@erlend-aasland

erlend-aasland commented Jan 26, 2022

Copy link
Copy Markdown
ContributorAuthor

Go ahead and land it!

I can't; I don't have the commit bit :)

@gvanrossum

gvanrossum commented Jan 26, 2022

Copy link
Copy Markdown
Member

What?! I thought you did. You should. Who's mentoring you?

@gvanrossum
gvanrossum merged commit 3eb3b4f into python:mainJan 26, 2022
@miss-islington

miss-islington commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland and @gvanrossum, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3eb3b4f270757f66c7fb6dcf5afa416ee1582a4b 3.10

@miss-islington

miss-islington commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

Sorry @erlend-aasland and @gvanrossum, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 3eb3b4f270757f66c7fb6dcf5afa416ee1582a4b 3.9

@JelleZijlstra

JelleZijlstra commented Jan 26, 2022

Copy link
Copy Markdown
Member

I can't; I don't have the commit bit :)

I was surprised when I learned that too, I feel like I've seen your name around CPython a lot :)

@erlend-aasland

erlend-aasland commented Jan 26, 2022

Copy link
Copy Markdown
ContributorAuthor

What?! I thought you did. You should. Who's mentoring you?

First @corona10, now @pablogsal 🙂

(BTW, I'll fix the backports.)

@erlend-aasland

erlend-aasland commented Jan 26, 2022

Copy link
Copy Markdown
ContributorAuthor

I was surprised when I learned that too, I feel like I've seen your name around CPython a lot :)

I've been around a year or two, IIRC :)

@pablogsal

pablogsal commented Jan 26, 2022

Copy link
Copy Markdown
Member

What?! I thought you did. You should. Who's mentoring you?

We have already offer the promotion a couple of times, we are working on it 😉

@erlend-aasland
erlend-aasland deleted the sqlite-test-udf-str-with-null branch January 26, 2022 21:12
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jan 26, 2022
Erlend Egeberg Aasland
[3.10] bpo-43853: Expand test suite for SQLite UDF's (pythonGH-27642).
f0fd0bd
(cherry picked from commit 3eb3b4f)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Jan 30, 2022
@bedevere-bot

bedevere-bot commented Jan 30, 2022

Copy link
Copy Markdown

GH-31030 is a backport of this pull request to the 3.10 branch.

@erlend-aasland

erlend-aasland commented Jan 30, 2022

Copy link
Copy Markdown
ContributorAuthor

Backporting to 3.9 from GH-31030.

@JelleZijlstraJelleZijlstra mentioned this pull request Feb 19, 2022
Merged
JelleZijlstra pushed a commit that referenced this pull request Feb 21, 2022
Erlend Egeberg Aasland
[3.10]bpo-43853: Expand test suite for SQLite UDF's (GH-27642) (GH-3…
ba457fe
…1030)
* [3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642).
(cherry picked from commit 3eb3b4f)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
* Fix test_func_return_too_large_int
GH-27613 (bpo 44839) was not backported, so exceptions differ between
main (3.11) and older versions.
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Feb 25, 2022
Erlend Egeberg Aasland
[3.9] bpo-43853: Expand test suite for SQLite UDF's (pythonGH-27642) (p…
b466671
…ythonGH-31030)
(cherry picked from commit 3eb3b4f)
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Feb 26, 2022
Erlend E. Aasland
AdaptpythonGH-27642tests
d3186be
miss-islington pushed a commit that referenced this pull request Mar 2, 2022
Erlend Egeberg Aasland
[3.9]bpo-43853: Expand test suite for SQLite UDF's (GH-27642) (GH-31030
3ea2a8f
) (GH-31586)
(cherry picked from commit 3eb3b4f)
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
Erlend Egeberg Aasland@hello-adam
[3.9] bpo-43853: Expand test suite for SQLite UDF's (pythonGH-27642) (p…
3743da6
…ythonGH-31030) (pythonGH-31586)
(cherry picked from commit 3eb3b4f)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes
@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag
@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka

Assignees

@gvanrossumgvanrossum

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@erlend-aasland@serhiy-storchaka@JelleZijlstra@gvanrossum@miss-islington@pablogsal@bedevere-bot@the-knights-who-say-ni