Skip to content

bpo-42255: Deprecate webbrowser.MacOSX from Python 3.11 - #27837

Merged
ambv merged 2 commits into
python:mainfrom
corona10:bpo-42255
Sep 3, 2021
Merged

bpo-42255: Deprecate webbrowser.MacOSX from Python 3.11#27837
ambv merged 2 commits into
python:mainfrom
corona10:bpo-42255

Conversation

@corona10

@corona10corona10 commented Aug 19, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

corona10
corona10 commented Aug 19, 2021
View reviewed changes
Comment threadDoc/library/webbrowser.rst Outdated

@corona10corona10Aug 19, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should be backported

@ambvambvSep 3, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can reasonably call renaming MacOSX to MacOSXOSAScript a "backport" of this PR since it is about the deprecation. I'll of course accept PRs to 3.10 and 3.9 that make this doc change.

corona10
corona10 commented Aug 19, 2021
View reviewed changes
Comment threadDoc/library/webbrowser.rst Outdated

@corona10corona10Aug 19, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should be backported

@corona10
corona10 requested a review from ambvSeptember 1, 2021 03:05
@corona10

corona10 commented Sep 1, 2021

Copy link
Copy Markdown
MemberAuthor

@ambv Can you please take a look? cc @ned-deily@ronaldoussoren

ambv
ambv requested changes Sep 2, 2021
View reviewed changes

@ambvambv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PEP 387 for our deprecation policy.

Comment threadDoc/library/webbrowser.rst Outdated
Comment threadDoc/whatsnew/3.11.rst Outdated
Comment threadMisc/NEWS.d/next/Library/2021-08-19-23-49-10.bpo-42255.ofe3ms.rst Outdated
@bedevere-bot

bedevere-bot commented Sep 2, 2021

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@ambv

ambv commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

@corona10, please also resolve the conflict with main.

@corona10

corona10 commented Sep 3, 2021

Copy link
Copy Markdown
MemberAuthor

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Sep 3, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@ambv: please review the changes made to this pull request.

@ambv

ambv commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

@corona10, your force-push undid the changes to 3.13. I'll make them myself since you had them in a035970b79921a66d29688b3a30e5108af3fa82c.

@ambv
ambv merged commit bc1c49f into python:mainSep 3, 2021
@corona10
corona10 deleted the bpo-42255 branch September 3, 2021 16:21
@corona10

corona10 commented Sep 3, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@ambv Thanks :)
I notice it now that I made mistake while rebased on my local environment :(

@ronaldoussorenronaldoussoren mentioned this pull request May 23, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronaldoussorenronaldoussorenAwaiting requested review from ronaldoussoren
@ned-deilyned-deilyAwaiting requested review from ned-deily
@ambvambvAwaiting requested review from ambv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10@bedevere-bot@ambv@the-knights-who-say-ni