Skip to content

bpo-42560: simplify/merge architecture info in Tkinter docs - #27839

Merged
ambv merged 2 commits into
python:mainfrom
roseman:tkinter-docs-arch-related
Aug 23, 2021
Merged

bpo-42560: simplify/merge architecture info in Tkinter docs#27839
ambv merged 2 commits into
python:mainfrom
roseman:tkinter-docs-arch-related

Conversation

@roseman

@rosemanroseman commented Aug 19, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor
  • drop Tix from architecture section (will add back to modules in separate PR)
  • merge simplified and corrected version of "How Tk and Tkinter are Related" into architecture to improve flow and remove redundancy

https://bugs.python.org/issue42560

@bedevere-botbedevere-bot added awaiting review docs Documentation in the Doc dir labels Aug 19, 2021
E-Paine
E-Paine reviewed Aug 21, 2021
View reviewed changes
Comment threadDoc/library/tkinter.rst
third-party Tcl package, an add-on for Tk that adds several new widgets.
Python bindings are found in the :mod:`tkinter.tix` module.
It's deprecated in favor of Ttk.
Internally, Tk and Ttk use facilities of the underlying operating system,

@E-PaineE-PaineAug 21, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth noting Tk's "draw everything" approach?

Comment threadDoc/library/tkinter.rst Outdated
@ambv@E-Paine
Update Doc/library/tkinter.rst
a8eb955
Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
@ambv
ambv merged commit e41912c into python:mainAug 23, 2021
@miss-islington

miss-islington commented Aug 23, 2021

Copy link
Copy Markdown
Contributor

Thanks @roseman for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 23, 2021
@roseman@miss-islington
bpo-42560: simplify/merge architecture info in Tkinter docs (pythonGH…
1b0ab51
…-27839)
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
(cherry picked from commit e41912c)
Co-authored-by: Mark Roseman <mark@markroseman.com>
@miss-islington

miss-islington commented Aug 23, 2021

Copy link
Copy Markdown
Contributor

Sorry, @roseman and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e41912c6348362489d2514565a70782591f23902 3.9

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Aug 23, 2021
@bedevere-bot

bedevere-bot commented Aug 23, 2021

Copy link
Copy Markdown

GH-27920 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Aug 23, 2021
@miss-islington@roseman
bpo-42560: simplify/merge architecture info in Tkinter docs (GH-27839)
e479510
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
(cherry picked from commit e41912c)
Co-authored-by: Mark Roseman <mark@markroseman.com>
@hpmasonhpmasonmannequin mentioned this pull request Nov 3, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@E-PaineE-PaineE-Paine left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ambvambv

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@roseman@miss-islington@bedevere-bot@E-Paine@ambv@the-knights-who-say-ni