Uh oh!
There was an error while loading. Please reload this page.
bpo-45094: Add Py_ALWAYS_INLINE macro - #28141
Closed
vstinner wants to merge 2 commits into
Closed
Conversation
Add Py_ALWAYS_INLINE macro to ask the compiler to always inline a static inline function. Use Py_ALWAYS_INLINE on static inline functions: * Py_DECREF(), Py_XDECREF() * Py_INCREF(), Py_XINCREF() * Py_IS_TYPE() * Py_NewRef(), Py_XNewRef() * Py_REFCNT() * Py_SET_REFCNT(), Py_SET_SIZE(), Py_SET_TYPE()
vstinner
commented
Sep 3, 2021
MemberAuthor
Fidget-Spinner
left a comment
Member
There was a problem hiding this comment.
I just have some minor nits with wording and usage.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| #endif | ||
| // Ask the compiler to always inline a static inline function. The compiler is | ||
| // free is ignored this "hint". This attribute can be used to avoid increasing |
There was a problem hiding this comment.
Suggested change
| // free is ignored this "hint". This attribute can be used to avoid increasing | |
| // free to ignore this "hint". This attribute can be used to avoid increasing |
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland
approved these changes
Sep 3, 2021
erlend-aasland
left a comment
Contributor
There was a problem hiding this comment.
I have nothing to add after Ken's comments. LGTM :)
vstinner
commented
Sep 4, 2021
MemberAuthor
Sadly, it doesn't seem to solve PR #28128 problem. |
vstinner
marked this pull request as draft
September 4, 2021 01:15
vstinner
commented
Sep 7, 2021
MemberAuthor
I rejected https://bugs.python.org/issue45094#msg401272 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Py_ALWAYS_INLINE macro to ask the compiler to always inline a
static inline function.
Use Py_ALWAYS_INLINE on static inline functions:
https://bugs.python.org/issue45094