Uh oh!
There was an error while loading. Please reload this page.
bpo-45115: Enable optimiaztions on Windows debug build - #28181
Conversation
On Windows, enable compiler optimizations on the debug build to make tests run faster and to reduce the stack memory usage, especially with static inline functions used in Python public header files. The Windows GitHub Actions now build Python in debug mode to catch more bugs.
vstinner
commented
Sep 6, 2021
I modified my PR #28128 to see if enabling compiler optimizations fix test_exceptions when Py_TYPE() macro is converted to a static inline function. |
vstinner
commented
Sep 6, 2021
[Reference] Timing of a release build (with optimizations), from PR #28180:
[With this PR] GitHub Action jobs with Python built in debug mode with optimizations:
Currently, the slowest job is the Address Sanitizer. IMO as soon as the Windows jobs are faster than the Address Sanitizer job, the little slowdown of this PR on GitHub Action is accepted. And it's way better to test Python on Windows in debug mode! |
vstinner
commented
Sep 6, 2021
Building Python in debug mode does fix test_exceptions crash when Py_TYPE() macro is converted to a static inline function: |
zooba
left a comment
There was a problem hiding this comment.
Blocking this PR explicitly until we've had the discussion on the issue tracker.
bedevere-bot
commented
Sep 6, 2021
When you're done making the requested changes, leave the comment: |
vstinner
commented
Sep 6, 2021
Ok, I convert this PR to a draft to prevent merging it by mistake. |
vstinner
commented
Sep 7, 2021
I rejected my issue: https://bugs.python.org/issue45115#msg401273 |
On Windows, enable compiler optimizations on the debug build to make
tests run faster and to reduce the stack memory usage, especially
with static inline functions used in Python public header files.
The Windows GitHub Actions now build Python in debug mode to catch
more bugs.
https://bugs.python.org/issue45115